Structured Logging #13015
Merged
Structured Logging #13015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
structured-logging
branch
17 times, most recently
from
7327f19 to
dda0900
Compare
Logging messages now accept a payload of the form: [(string * Dyn.t) list] in addition to the message. They are also replicated to the trace file where they structure is preserved. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
structured-logging
branch
from
dda0900 to
e2fca6f
Compare
Member
Author
|
This PR touches a bunch of tests and logging statements in trivial ways so it's a bit of a pain to rebase. The changes are all trivial conversion from logs to events. @Alizter give this us a look-over anyhow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining a separate _build/log, we fold it into the trace and produce it by default. The trace already has a lot more valuable information than the log, so the combined information provides a better debugging experienced. Log messages also contain structured payloads, which makes them useful with automation/scripting. This is demonstrated in the changes in the tests.
Fixes #12904 except for the last point. That will come in a subsequent PR.