[tooling] Associate Uids to items that don't have a concrete definition #14120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the reduced shape does have one.
voodoos
changed the title
Octachron
reviewed
Jul 2, 2025
| Missing uid: Z.s (File "index_aliases.ml", line 45, characters 8-11) | ||
| Alias: Index_aliases.23 -> Approximated: Index_aliases.22: | ||
| Resolved decl: [G]Index_aliases.2: | ||
| Z.s (File "index_aliases.ml", line 45, characters 8-11) |
There was a problem hiding this comment.
The comment in the test file should be updated.
modules' items usages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #12142 the compiler index items usages and write that information into the cmt files. This indexation enable tools like Merlin to answer project-wide occurrences and renaming queries. Since this is based on mapping definitions uids to locations, it means that usages of objects that don't have a concrete definition at compile time are missing in the index.
This happens in a least two cases: when using components of a functor's parameter inside this functor body and when unpacking a first class module.
This PR proposes to generate new uids that are specific to one module parameter, or to one unpacking. These uids are paired with their declaration's uids, allowing feature like renaming to adequately handle these usages.
This PR also move the logic to pair uids to the shape module to prevent a cyclic dependency.
cc @Octachron (and maybe @gasche ?)