fix potential overflow by casting one operand to lager integer type #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 178 178
Lines 10338 10338
=======================================
Hits 5705 5705
Misses 4633 4633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nautaa
reviewed
May 12, 2025
|
Changed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem were solved in this pull request?
Issue Number: close #xxx
#534
Problem:
Fix code scanning alert - Multiplication result converted to larger type #534
What is changed and how it works?
Basically just casted one of the operand to 'long'. I wasn't sure if it was meant to be an unsigned type for example size_t and that's why I stuck to long.
Other information