Skip to content

Conversation

CubeLov
Copy link
Contributor

@CubeLov CubeLov commented May 17, 2025

What problem were solved in this pull request?

Issue Number: close #xxx
#278
Problem:
Fixed the problem that expressions like 1-1 cannot be recognized correctly

What is changed and how it works?

Just like the discussion in the #278, parse '-' into an expression

Other information

@CLAassistant
Copy link

CLAassistant commented May 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nautaa nautaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution, can you also modify docs in docs/docs/design/miniob-sql-expression.md?

@CubeLov
Copy link
Contributor Author

CubeLov commented May 19, 2025

thanks for your contribution, can you also modify docs in docs/docs/design/miniob-sql-expression.md?

Sure! I've completed the modification now.

@CubeLov CubeLov requested a review from nautaa May 19, 2025 09:51
Copy link
Member

@nautaa nautaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CubeLov CubeLov closed this May 19, 2025
@CubeLov CubeLov reopened this May 19, 2025
@nautaa nautaa merged commit 801bfef into oceanbase:main May 20, 2025
29 checks passed
@CubeLov CubeLov deleted the fix/issue-278-negative_number branch May 20, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants