Skip to content

Conversation

sats-23
Copy link

@sats-23 sats-23 commented Sep 3, 2025

Fixes #76

Status:
Operator comes with a SA (rsct-operator-controller-manager) under NS (rsct-operator-system).
RSCT CR comes with a SA (rsct) under fixed NS (rsct-operator-system).

Solution:
-Provide SA (rsct-operator-controller-manager) with RBAC permissions to be able to patch SCC on behalf of SA (rsct).
-The controller's reconcile logic grants the SA (rsct) with privileged SCC.
-Now rsct pods can be deployed into any NS without having to manually deploy CR and CRB.

Test Operator image: sats23/sats:rsct

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @sats-23! It looks like this is your first PR to ocp-power-automation/rsct-operator 🎉

@sats-23 sats-23 marked this pull request as ready for review September 3, 2025 08:55
@sats-23
Copy link
Author

sats-23 commented Sep 3, 2025

/cc @varad-ahirwadkar

@sats-23 sats-23 reopened this Sep 17, 2025
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sats-23
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sats-23
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sats-23
Copy link
Author

sats-23 commented Sep 17, 2025

@mkumatag @varad-ahirwadkar Please have a look with the new approach
#140 (comment)

@varad-ahirwadkar
Copy link
Collaborator

Hi @sats-23 .
Since the implementation imports github.com/openshift/api and relies on SecurityContextConstraints (SCC), will this operator still work on a Kubernetes cluster?

As SCCs are OpenShift-specific, I'm wondering if this change restricts the operator to OpenShift only, or if we should consider a fallback mechanism check for broader compatibility.

@sats-23
Copy link
Author

sats-23 commented Sep 19, 2025

Hi @sats-23 . Since the implementation imports github.com/openshift/api and relies on SecurityContextConstraints (SCC), will this operator still work on a Kubernetes cluster?

As SCCs are OpenShift-specific, I'm wondering if this change restricts the operator to OpenShift only, or if we should consider a fallback mechanism check for broader compatibility.

Hi @varad-ahirwadkar, please refer to c82ce64 for the fallback logic

@varad-ahirwadkar
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCP Cluster: RSCT deployment fails outside the rsct-operator-system namespace
3 participants