-
Notifications
You must be signed in to change notification settings - Fork 8
Allow rsct pods to be deployed in any namespace #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome @sats-23! It looks like this is your first PR to ocp-power-automation/rsct-operator 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sats-23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sats-23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mkumatag @varad-ahirwadkar Please have a look with the new approach |
Hi @sats-23 . As SCCs are OpenShift-specific, I'm wondering if this change restricts the operator to OpenShift only, or if we should consider a fallback mechanism check for broader compatibility. |
Hi @varad-ahirwadkar, please refer to c82ce64 for the fallback logic |
/lgtm |
Fixes #76
Status:
Operator comes with a SA (rsct-operator-controller-manager) under NS (rsct-operator-system).
RSCT CR comes with a SA (rsct) under fixed NS (rsct-operator-system).
Solution:
-Provide SA (rsct-operator-controller-manager) with RBAC permissions to be able to patch SCC on behalf of SA (rsct).
-The controller's reconcile logic grants the SA (rsct) with privileged SCC.
-Now rsct pods can be deployed into any NS without having to manually deploy CR and CRB.
Test Operator image: sats23/sats:rsct