Prevent double-encoding of URLs in config-prettyfaces #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ajkyffin wants to merge 1 commit into ocpsoft:develop-jakartaee-10 from ajkyffin:develop-jakartaee-10

ajkyffin commented Jul 10, 2024

URLs are being double-encoded, resulting in e.g. %2520 for a space character.

The URL returned by ExtractedValuesURLBuilder.buildURL is already encoded here:

rewrite/config-prettyfaces/src/main/java/com/ocpsoft/pretty/faces/beans/ExtractedValuesURLBuilder.java

Line 89 in b33b345

result = parser.getMappedURL(parameterValues).encode();

so it should not be encoded again.


          fix: only encode URL once

53c29c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet