[IMP] format: add custom format side panel #7241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
hokolomopo
force-pushed
the
master-custom-format-panel-adrm
branch
2 times, most recently
from
0db08e7 to
14c457b
Compare
Comment on lines
+54
to
+56
| this.model.selection.observe(this, { | ||
| handleEvent: this.handleSelectionEvent.bind(this), | ||
| }); |
There was a problem hiding this comment.
this.onDispose(() => {
// release the selection, sinon, bim: memory leak
});There was a problem hiding this comment.
Good catch ! There is no method to unobserve in the selection processor tho 😅
There was a problem hiding this comment.
Added another commit to add an unobserve method :)
In the test `can set cell format`, after opening the `More Formats` tool, we do a snapshot of the whole fixture for testing purposes. Snapshotting the whole fixture, is useless and guarantees that any change will need to update this unrelated snapshot. Task: 3149088
This commits adds a check for the command `SET_FORMATTING` to avoid useless revisions when the command doesn't change the format/style of any cell. Task: 3149088
The selection stream processor was missing a method to stop observing events after starting to observe them, which could lead to memory leak. The `AggregateStatisticsStore` was never releasing its observation, which was not a problem in practice because the store is never disposed, but let's fix it anyway. Task: 3149088
This commit adds a side panel for all number formats. This merges the old date format/currency format panels into a single "More formats" panel, with tabs for each category of formats (number, date, currency). Task: 3149088
hokolomopo
force-pushed
the
master-custom-format-panel-adrm
branch
from
14c457b to
9c6f863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit adds a side panel for all number formats. This merges
the old date format/currency format panels into a single "More formats"
panel, with tabs for each category of formats (number, date, currency).
Task: 3149088
review checklist