[IMP] controllers #497
Open
[IMP] controllers #497
+315
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cammarosano
force-pushed
the
alpha-request_type-rcdl
branch
2 times, most recently
from
1229e40 to
c9ba24d
Compare
cammarosano
force-pushed
the
alpha-request_type-rcdl
branch
2 times, most recently
from
41126a7 to
8794251
Compare
- add evaluation for odoo.http.request: - up to 15.2: WebRequest class - since 15.3: Request class - add env variable to Request class (15.3+ only, as it is a property before that) - add evaluation to (Request/WebRequest).env: Environment | None This allows us for better tooling in controllers, which use odoo.http.request extensively.
This enables getting an evaluation for `request.env["some.model"]`, even though `env` has two possible evaluations (Environment and None).
cammarosano
force-pushed
the
alpha-request_type-rcdl
branch
from
8794251 to
80b805c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing features related to controllers.
requestnow evaluates toRequestclassrequest.envnow evaluates toEnvironment | Nonerequest.env["res.partner"]evaluates to the modelNext steps:
In a Controller,
self.envstill does not work, asenvis a property (which simply returnsrequest.env), and properties are not resolved to their return types.Support for resolving property types is introduced by #511, which should then:
self.envin aControllerclassrequest.envbefore 15.3, in whichrequestis an instance ofWebRequest, which in turn hasenvas a property.