Skip to content

Fix panicking on models defined outside an odoo module + refactor the is model check #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mmahrouss wants to merge 2 commits into
base: alpha
Choose a base branch
from
Open

Fix panicking on models defined outside an odoo module + refactor the is model check #510

mmahrouss wants to merge 2 commits into from

Conversation

@mmahrouss
Copy link
Collaborator

@mmahrouss mmahrouss commented Dec 11, 2025

No description provided.

@mmahrouss
Copy link
Collaborator Author

mmahrouss commented Dec 11, 2025 •
edited
Loading

Check that _register = False, is there for all supported version.
While this is nice and concise on master, we should make sure it is still backwards-compatible.

Edit: it exists sine 14.0, so that check should be correct, if it breaks, then the tests will also fail.

@mmahrouss mmahrouss force-pushed the alpha-refactor-test_symbol_is_model-mdms branch from 9dbf5e4 to 534bb8c Compare December 11, 2025 15:43
@mmahrouss mmahrouss force-pushed the alpha-refactor-test_symbol_is_model-mdms branch from 534bb8c to 3f68d8e Compare December 12, 2025 10:13
@mmahrouss
[FIX] Avoid crashing on model classes outside a module
69c9c4b 
Check if class model is in a module, otherwise do not mark it as a model
This is to avoid crashing later due to the class not being in a model.
The crash to avoid is in `core.model.Model.get_symbols`
@mmahrouss mmahrouss requested a review from fda-odoo December 16, 2025 12:38
@mmahrouss mmahrouss self-assigned this Dec 16, 2025
@mmahrouss mmahrouss added the bug Something isn't working label Dec 16, 2025
@mmahrouss mmahrouss changed the title WIP: [IMP] refactor odoo step is_model Fix panicking on models defined outside an odoo module + refactor the is model check Dec 16, 2025
@mmahrouss mmahrouss marked this pull request as ready for review December 16, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fda-odoo fda-odoo Awaiting requested review from fda-odoo

Assignees

@mmahrouss mmahrouss

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mmahrouss