Rankups.yml suggestion #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicBOMB
reviewed
May 12, 2021
src/main/resources/rankups.yml
Outdated
| # this will run when a player ranks up from A to B. | ||
| #- 'say {PLAYER} well done for ranking up from {OLD_RANK} to {RANK}!' | ||
| Bexample: | ||
| ExampleA: # This name doesn't matter, it can be anything you want! |
Collaborator
There was a problem hiding this comment.
But this does matter. It must at least be unique from all the other headings.
NicBOMB
reviewed
May 12, 2021
src/main/resources/rankups.yml
Outdated
| #- 'say {PLAYER} well done for ranking up from {OLD_RANK} to {RANK}!' | ||
| Bexample: | ||
| ExampleA: # This name doesn't matter, it can be anything you want! | ||
| rank: 'A' # This is the rank where you start from. Use the displayname if you have it! |
Collaborator
There was a problem hiding this comment.
should be "Use the from displayname.<name> if you use displaynames."
NicBOMB
reviewed
May 12, 2021
src/main/resources/rankups.yml
Outdated
| Bexample: | ||
| ExampleA: # This name doesn't matter, it can be anything you want! | ||
| rank: 'A' # This is the rank where you start from. Use the displayname if you have it! | ||
| next: 'B' # This is the rank where you go next. Read it as "From A to B" |
Collaborator
There was a problem hiding this comment.
change to "This is the next rank users are moved into."
NicBOMB
reviewed
May 12, 2021
NicBOMB
reviewed
May 12, 2021
This is my version of the auto generated rankups.yml file that I feel better shows how to use Rankup and its features to new users. It shows the new users the basics.
If there's a possibility that the tree is going to be null
we should account for it rather than let the plugin spam like:
Caused by: java.lang.NullPointerException: Cannot invoke "sh.okx.rankup.ranks.RankTree.asList()" because "this.tree" is null
at sh.okx.rankup.ranks.RankList.getByPlayer(RankList.java:110) ~[Rankup-3.13.2.jar:?]
some requirements had their names listed in RankupPlugin.java this is useful, but was not consistent. Also, indentation was incorrect for all `new *Requirement` lines
thinking like an array programmer the Getter also enables other plugins/spigot to ask if Rankup supports a specific locale
No reason to add more visual complexity when we should simply ask for `getValueString()` instead of `getValuesString()`.
credit to @Voltmage for being a guinea pig
bump version
NicBOMB
force-pushed
the
new-rankups.yml
branch
from
7c0d135 to
360e48d
Compare
NicBOMB
force-pushed
the
new-rankups.yml
branch
from
c697bb0 to
3801db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my version of the auto generated rankups.yml file that I feel better shows how to use Rankup and its features to new users. It shows the new users the basics.