Skip to content

adds Dockerfile, can add a PR later for publishing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iMartyn
Copy link

@iMartyn iMartyn commented Jul 18, 2025

Dockerfile that creates a simple clean debian-based container, grabbing the libraries needed using ldd.

If you like I can craft a github action that adds a build and publish to ghcr.io (github container registry), so people can pull the docker image and just use it.

Also I can probably contribute a helm chart for kubernetes :-)

@iMartyn iMartyn marked this pull request as draft July 18, 2025 16:31
@iMartyn
Copy link
Author

iMartyn commented Jul 18, 2025

This needs more, it seems, rust is fine but node for node-red gui is needed.

also adds some cache niceness for build speed in CI
@iMartyn iMartyn marked this pull request as ready for review July 18, 2025 22:37
@iMartyn
Copy link
Author

iMartyn commented Jul 18, 2025

Should be good to run once #15 is working. I've tested it with socat running in the container and firefox loads the ui. There were a couple of error messages on first load but I don't know if it's the docker image or the fact that it's edgelinkd not nodered at the backend.

There's for sure more that the Dockerfile could do such as taking env vars to influence the command-line parameters etc. but we can iterate there, especially as I don't know if you plan to do that natively in rust at some point.

P.S. I'm probably not going to look at this for another week because I'm away. I used my travel time to work this up :-)

@oldrev
Copy link
Owner

oldrev commented Jul 19, 2025

First of all, thank you very much for your contribution.

Your Dockerfile looks good, but you may have misunderstood the current state of the project. It's basically a working prototype at this point and is still far from being something people can actually "use".

Plus, my primary target platform is ultra-low-memory embedded Linux systems (e.g., 64MB or even 32MB), where using Docker doesn't really make sense.

@iMartyn
Copy link
Author

iMartyn commented Aug 1, 2025

Yeah, that's understandable, and yes, I get that the target is lower-memory systems, but I run everything in kubernetes, even on low-memory systems, such as SBCs with (admittedly hugely more than your example) of 512Mb ram. I still think that there is benefit for switching from node-red full to edgelinkd for those of us who want a more streamlined approach on "bigger" machines. Docker doesn't actually add much overhead in ram usage, disk usage, absolutely, but not ram or CPU. Anyway, if you don't want the overhead of maintaining it if you accepted the PR, that's fine, I'll still probably host it myself, just y'know, being a good open-source citizen and giving back upstream :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants