Switch to strict mode and fix this usage issue
#516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #324 (allowing lunr.js import as module and usage in other strict environments) by switching lunr itself to strict mode and fixing `this` usage. `wrapper_end` was updated to the latest version of template, which uses `self` to access window and thus works in strict mode. `lurn.utils.warn` was changed as in #411 Tests added work both in Node and browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324 (allowing lunr.js import as module and usage in other strict environments) by switching lunr itself to strict mode and fixing
thisusage.wrapper_endwas updated to the latest version of template, which usesselfto access window and thus works in strict mode.lurn.utils.warnwas changed as in #411.Added tests check conditional usage of console. Tests succeed in both Node and browser.