added firstItem, lastItem and a unit test for pagination #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a unit test for pagination
|
Thanks for the pr. How do I make changes? Haven't needed to before, but there are some things I'll want to update. |
|
I suggest you accept the pull request and do the changes you like. |
|
Gotcha thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes issue #6
note: i used firstItem() and lastItem() which seems to describe the functionality very good.
see laravel paginator as widely used reference implementation http://laravel.com/api/5.0/Illuminate/Contracts/Pagination/Paginator.html