Skip to content

Fix spelling in utils_log.c* #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Fix spelling in utils_log.c* #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/utils/utils_log.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ char const __umf_str_1__all_cmake_vars[] =

typedef struct {
bool enableTimestamp;
bool enamblePid;
bool enablePid;
utils_log_level_t level;
utils_log_level_t flushLevel;
FILE *output;
Expand Down Expand Up @@ -203,7 +203,7 @@ static void utils_log_internal(utils_log_level_t level, int perror,
h_size -= tmp;
}

if (loggerConfig.enamblePid) {
if (loggerConfig.enablePid) {
ASSERT(h_size > 0);
tmp = snprintf(h_pos, h_size, "PID:%-6lu TID:%-6lu ",
(unsigned long)pid, (unsigned long)tid);
Expand Down Expand Up @@ -305,9 +305,9 @@ void utils_log_init(void) {
}

if (utils_parse_var(envVar, "pid:yes", NULL)) {
loggerConfig.enamblePid = 1;
loggerConfig.enablePid = 1;
} else if (utils_parse_var(envVar, "pid:no", NULL)) {
loggerConfig.enamblePid = 0;
loggerConfig.enablePid = 0;
}

if (utils_parse_var(envVar, "level:debug", NULL)) {
Expand Down Expand Up @@ -338,7 +338,7 @@ void utils_log_init(void) {
"level: %s, flush: %s, pid: %s, timestamp: %s)",
level_to_str(loggerConfig.level),
level_to_str(loggerConfig.flushLevel),
bool_to_str(loggerConfig.enamblePid),
bool_to_str(loggerConfig.enablePid),
bool_to_str(loggerConfig.enableTimestamp));
}

Expand Down Expand Up @@ -392,7 +392,7 @@ static umf_result_t CTL_READ_HANDLER(pid)(void *ctx,
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}

*arg_out = loggerConfig.enamblePid;
*arg_out = loggerConfig.enablePid;
return UMF_RESULT_SUCCESS;
}

Expand All @@ -409,9 +409,8 @@ static umf_result_t CTL_WRITE_HANDLER(pid)(void *ctx,
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}

loggerConfig.enamblePid = arg_in;
LOG_INFO("Logger print pid %s set to",
bool_to_str(loggerConfig.enamblePid));
loggerConfig.enablePid = arg_in;
LOG_INFO("Logger print pid %s set to", bool_to_str(loggerConfig.enablePid));
return UMF_RESULT_SUCCESS;
}

Expand Down
4 changes: 2 additions & 2 deletions test/utils/utils_log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ void helper_checkConfig(utils_log_config_t *expected, utils_log_config_t *is) {
EXPECT_EQ(expected->flushLevel, is->flushLevel);
EXPECT_EQ(expected->output, is->output);
EXPECT_EQ(expected->enableTimestamp, is->enableTimestamp);
EXPECT_EQ(expected->enamblePid, is->enamblePid);
EXPECT_EQ(expected->enablePid, is->enablePid);
}

TEST_F(test, parseEnv_errors) {
Expand Down Expand Up @@ -236,7 +236,7 @@ TEST_F(test, parseEnv) {
}
expected_stream = output.second;
b.enableTimestamp = timestamp.second;
b.enamblePid = pid.second;
b.enablePid = pid.second;
b.flushLevel = (utils_log_level_t)flushLevel.second;

b.level = (utils_log_level_t)logLevel.second;
Expand Down