Add schedule cancel and list logic
#2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasefleming
requested review from
Kay-Zee,
bjartek,
janezpodhostnik,
jribbink,
mfbz and
nvdtf
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mfbz
reviewed
Oct 20, 2025
| // Check if mainnet | ||
| if chainID == flowsdk.Mainnet { | ||
| // Check if mainnet for scheduling contracts | ||
| if chainID == flowsdk.Mainnet && (contract == FlowTransactionSchedulerUtils || contract == FlowTransactionScheduler) { |
There was a problem hiding this comment.
Should we remove this considering the release is after mainnet deployment?
There was a problem hiding this comment.
I will in the next PR
mfbz
reviewed
Oct 20, 2025
| } | ||
|
|
||
| if chainID == flowsdk.Mainnet { | ||
| return nil, fmt.Errorf("transaction scheduling is not yet supported on mainnet") |
There was a problem hiding this comment.
Same here, should we remove this considering this release goes out after mainnet release?
jribbink
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #???
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer