Skip to content

Make verifyInputTensor true by default #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make verifyInputTensor true by default #3079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685ecb9
change
chentong319 Feb 17, 2025
d91dc99
handle null
chentong319 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Compiler/CompilerOptions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,8 +577,8 @@ static llvm::cl::opt<bool, true> verifyInputTensorsOpt("verifyInputTensors",
llvm::cl::desc(
"Verify input tensors whenever the entry point function is called.\n"
"Data type and shape are verified. Enable this may introduce overhead "
"at runtime."),
llvm::cl::location(verifyInputTensors), llvm::cl::init(false),
"at runtime. Default is true"),
llvm::cl::location(verifyInputTensors), llvm::cl::init(true),
llvm::cl::cat(OnnxMlirOptions));

static llvm::cl::opt<bool, true> allowSortingOpt("allowSorting",
Expand Down
2 changes: 2 additions & 0 deletions src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ class KrnlEntryPointOpLowering : public OpRewritePattern<KrnlEntryPointOp> {
auto JSONItemType = JSONItem->getString("type");
assert(JSONItemType && "failed to get type");
Type elemTy = parseType(JSONItemType.value(), rewriter.getContext());
if (elemTy) {
std::string elemTyStr;
llvm::raw_string_ostream dstream(elemTyStr);
dstream << elemTy;
Expand All @@ -461,6 +462,7 @@ class KrnlEntryPointOpLowering : public OpRewritePattern<KrnlEntryPointOp> {
"Wrong data type for the input " + std::to_string(i) + ": expect " +
elemTyStr,
false);
}

// Verify data rank.
auto JSONDimArray = JSONItem->getArray("dims");
Expand Down
Loading