Skip to content

Conversation

@olastrz
Copy link
Collaborator

@olastrz olastrz commented Oct 8, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (64877ed) to head (5b06e4d).

Files with missing lines Patch % Lines
PySDM/exporters/parcel_vtk_exporter.py 0.00% 72 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   86.50%   85.90%   -0.60%     
==========================================
  Files         412      413       +1     
  Lines       10372    10444      +72     
==========================================
  Hits         8972     8972              
- Misses       1400     1472      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olastrz olastrz changed the title Funcs and tuple for pv refactor Paraview code & parcel-model animations Nov 13, 2025
@slayoo
Copy link
Member

slayoo commented Nov 21, 2025

@olastrz, kudos for the new visualisation!

Here is some feedback on the code:

  • since we are creating a new examples subfolder, let's move the new notebook there and add badges pointing to it to the __init__.py file
  • let's add an entry in the examples/docs/pysdm_examples_landing.md list of examples
  • instead of the 17 "pylint disable:" comments, let's fix the issues reported by pylint (disable=protected-access seems to be the only inevitable one)
  • since we are adding a new module to PySDM - the exporter, we need to cover it with a unit test
  • the change of "mass_of_dry_air=44 * si.kg" to "mass_of_dry_air=66666 * si.kg," in the simulation.py files potentially influences other code in the Pyrcel example - if this setting is crucial, let's make it alterable from outside while keeping the original value as default
  • there is a leftover print statement and c:\Users\strza\Desktop\PySDM\examples\PySDM_examples\Pyrcel\../../../PySDM/exporters/ output present in the commited notebook
  • the paraview_simulation.py file name seems misleading as it does not perform any simulation
  • the except subprocess.CalledProcessError as e: print("Error during script execution:") print("STDERR:", e.stderr) print("STDOUT:", e.stdout) block seems unneeded as without the except statement, the same would be printed anyhow?
  • the sys.path.append(exporters_path) logic is not needed - we can do from PySDM.exporters import ...
  • for the camera position settings, let's do max 4 significant digits (now we have figures like 1548.945972263949)
  • let's remove any remaining code comments (and wherever these are needed to understand the code, let's include the relevant information in function or variable names)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants