-
Notifications
You must be signed in to change notification settings - Fork 17
Add environment variables to disable AO, CO, O11y for mage deploy: targets in Coder Environment
#935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces environment variable-based control for disabling Application Orchestration (AO), Cluster Orchestration (CO), and Observability (O11y) profiles during Coder environment deployments, aligning with AWS and OnPrem installer conventions.
Key changes:
- Adds support for
DISABLE_AO_PROFILE,DISABLE_CO_PROFILE, andDISABLE_O11Y_PROFILEenvironment variables - Replaces cluster profiles (
devanddev-minimal) with presets (dev-coderanddev-coder-minimal) for consistency with scorch-based deployments - Updates cluster template to conditionally include AO and CO profiles based on configuration flags
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mage/config.go | Adds environment variable parsing logic and conditional preset overrides for AO, CO, and O11y profiles |
| mage/Magefile.go | Updates deployment targets to use new preset files and removes deprecated cluster creation methods |
| orch-configs/templates/cluster.tpl | Adds conditional inclusion of app-orch and cluster-orch profiles, plus conditional dockerCache rendering |
| orch-configs/presets/dev-coder.yaml | New preset file for full Coder environment with all features enabled |
| orch-configs/presets/dev-coder-minimal.yaml | New minimal preset file for Coder environment with limited features |
| orch-configs/clusters/dev.yaml | Removed cluster profile, replaced by preset |
| orch-configs/clusters/dev-minimal.yaml | Removed cluster profile, replaced by preset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Introduces the three environment variables, matching the AWS and OnPrem installers:
Removes the two cluster profiles
dev-minimalanddevand replaces them with a preset, consistent with how presets are applied from scorch. This yields consistency of implementation between the scorch-based and non-scorch-based Coder deployments.Updates installer/cluster.tpl to have EnableAppOrch and EnablleClusterOrch variables, consistent with how the rest of cluster.tpl is implemented for Coder environments.
Any Newly Introduced Dependencies
None.
How Has This Been Tested?
Tested using manual deployment.
Checklist: