Skip to content

Conversation

@scottmbaker
Copy link
Contributor

Description

Introduces the three environment variables, matching the AWS and OnPrem installers:

  • DISABLE_AO_PROFILE
  • DISABLE_CO_PROFILE
  • DISABLE_O11Y_PROFILE

Removes the two cluster profiles dev-minimal and dev and replaces them with a preset, consistent with how presets are applied from scorch. This yields consistency of implementation between the scorch-based and non-scorch-based Coder deployments.

Updates installer/cluster.tpl to have EnableAppOrch and EnablleClusterOrch variables, consistent with how the rest of cluster.tpl is implemented for Coder environments.

Any Newly Introduced Dependencies

None.

How Has This Been Tested?

Tested using manual deployment.

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@scottmbaker scottmbaker requested a review from Copilot October 22, 2025 22:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces environment variable-based control for disabling Application Orchestration (AO), Cluster Orchestration (CO), and Observability (O11y) profiles during Coder environment deployments, aligning with AWS and OnPrem installer conventions.

Key changes:

  • Adds support for DISABLE_AO_PROFILE, DISABLE_CO_PROFILE, and DISABLE_O11Y_PROFILE environment variables
  • Replaces cluster profiles (dev and dev-minimal) with presets (dev-coder and dev-coder-minimal) for consistency with scorch-based deployments
  • Updates cluster template to conditionally include AO and CO profiles based on configuration flags

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mage/config.go Adds environment variable parsing logic and conditional preset overrides for AO, CO, and O11y profiles
mage/Magefile.go Updates deployment targets to use new preset files and removes deprecated cluster creation methods
orch-configs/templates/cluster.tpl Adds conditional inclusion of app-orch and cluster-orch profiles, plus conditional dockerCache rendering
orch-configs/presets/dev-coder.yaml New preset file for full Coder environment with all features enabled
orch-configs/presets/dev-coder-minimal.yaml New minimal preset file for Coder environment with limited features
orch-configs/clusters/dev.yaml Removed cluster profile, replaced by preset
orch-configs/clusters/dev-minimal.yaml Removed cluster profile, replaced by preset

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant