Skip to content

fix: use-integer-and-default-environment-refresh-interval-to-60 #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use-integer-and-default-environment-refresh-interval-to-60 #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithClientConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ private static FlagsmithConfig initializeConfig(FlagsmithProviderOptions options
flagsmithConfig.withLocalEvaluation(options.isLocalEvaluation());
}

if (options.getEnvironmentRefreshIntervalSeconds() > -1) {
if (options.getEnvironmentRefreshIntervalSeconds() != null) {
flagsmithConfig.withEnvironmentRefreshIntervalSeconds(options.getEnvironmentRefreshIntervalSeconds());
}

Expand Down
3 changes: 2 additions & 1 deletion ...h/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ public class FlagsmithProviderOptions {
* Set environment refresh rate with polling manager. Only needed when local evaluation is true.
* Optional. Default: 60
*/
private int environmentRefreshIntervalSeconds = 60;
@Builder.Default
private Integer environmentRefreshIntervalSeconds = 60;

/**
* Controls whether Flag Analytics data is sent to the Flagsmith API See
Expand Down
9 changes: 9 additions & 0 deletions ...mith/src/test/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,15 @@ void shouldGetMetadataAndValidateName() {
.getName());
}

@Test
void shouldDefaultEnvironmentRefreshIntervalSecondsTo60() {
FlagsmithProviderOptions options = FlagsmithProviderOptions.builder()
.apiKey("API_KEY")
.localEvaluation(true)
.build();
assertEquals(Integer.valueOf(60), options.getEnvironmentRefreshIntervalSeconds());
}

@ParameterizedTest
@MethodSource("invalidOptions")
void shouldThrowAnExceptionWhenOptionsInvalid(FlagsmithProviderOptions options) {
Expand Down