-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Data Insights Retention to 90 days #25111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note: The PR title mentions "90 days" but the actual code changes update the retention from 7 to 30 days. You may want to update the title to match the implementation. DetailsAll four configuration files show the retention value being changed to
|
🔍 CI failure analysis for 6a44053: Three CI failures: one Playwright with flaky E2E tests, one Maven PostgreSQL with disk space exhaustion, and one Maven SonarCloud with same flaky integration test timeout - all infrastructure issues unrelated to config changes.IssueThree CI jobs failed from this workflow run: 1. playwright-ci-postgresql (3, 6) - Job 59911768891 - Flaky E2E tests Root Causes1. Playwright CI - Flaky E2E Test Failures3 test failures (browser crashes, assertion failures, data issues) after ~1h 12min. 2. Maven PostgreSQL CI - Disk Space ExhaustionError: Runner exhausted disk after ~2h 50min of building. Infrastructure issue. 3. Maven SonarCloud CI - Flaky Integration Test TimeoutTest Failure: Test Results: 7814 tests run, 1 failure, 707 skipped Analysis:
Flaky test indicators:
Pattern: This test consistently fails after ~3+ hours of CI testing, suggesting:
DetailsSummary by failure type:
Unrelated to this PR's changes: This PR only modifies Data Insights retention configuration (7→90 days). All three failures are caused by:
Code Review 👍 Approved with suggestionsStraightforward configuration update changing Data Insights retention from 7 to 90 days across all relevant schema and config files. Suggestions 💡 1 suggestionCode Quality: Unrelated .gitignore change bundled with retention updateThe addition of Impact: Makes the PR harder to review and understand, and can complicate git history and potential reverts. Suggested fix: Consider separating this into its own commit or PR, or at minimum document why this change is included in the PR description. Resolved ✅ 1 resolvedCode Quality: PR title says "90 days" but code changes to 30 days
Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
7to90days across schema definitions and application configsdataInsightsAppConfig.jsondefault value,DataInsightsApplication.jsonruntime configs, and marketplace definitionApplicationSchemas/DataInsightsApplication.jsonto reflect new 90-day retention default in UI formsThis will update automatically on new commits.