Skip to content

Conversation

@IceS2
Copy link
Contributor

@IceS2 IceS2 commented Jan 7, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Configuration update:
    • Changed Data Insights retention from 7 to 90 days across schema definitions and application configs
  • Schema files modified:
    • Updated dataInsightsAppConfig.json default value, DataInsightsApplication.json runtime configs, and marketplace definition
  • Frontend synchronization:
    • Updated ApplicationSchemas/DataInsightsApplication.json to reflect new 90-day retention default in UI forms

This will update automatically on new commits.


@IceS2 IceS2 changed the title Update Data Insights Retention to 30 days Update Data Insights Retention to 90 days Jan 7, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 7, 2026

Note: The PR title mentions "90 days" but the actual code changes update the retention from 7 to 30 days. You may want to update the title to match the implementation.

Details

All four configuration files show the retention value being changed to 30:

  • dataInsightsAppConfig.json: "default": 30
  • DataInsightsApplication.json: "retention": 30
  • Marketplace definition: "retention": 30
  • Frontend schema: "default": 30

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.25% (52217/80024) 43.14% (25833/59879) 46.53% (8094/17394)

@gitar-bot
Copy link

gitar-bot bot commented Jan 9, 2026

🔍 CI failure analysis for 6a44053: Three CI failures: one Playwright with flaky E2E tests, one Maven PostgreSQL with disk space exhaustion, and one Maven SonarCloud with same flaky integration test timeout - all infrastructure issues unrelated to config changes.

Issue

Three CI jobs failed from this workflow run:

1. playwright-ci-postgresql (3, 6) - Job 59911768891 - Flaky E2E tests
2. maven-postgresql-ci - Job 59911769087 - Disk space exhaustion
3. maven-sonarcloud-ci - Job 59911769008 - Flaky integration test timeout

Root Causes

1. Playwright CI - Flaky E2E Test Failures

3 test failures (browser crashes, assertion failures, data issues) after ~1h 12min.
Flaky E2E test pattern - unrelated to code changes.

2. Maven PostgreSQL CI - Disk Space Exhaustion

Error:

System.IO.IOException: No space left on device

Runner exhausted disk after ~2h 50min of building. Infrastructure issue.

3. Maven SonarCloud CI - Flaky Integration Test Timeout

Test Failure:

AppsResourceTest.post_trigger_app_200:369->assertAppRanAfterTriggerWithStatus:452
Max retries exceeded polling for eventual assert

Test Results: 7814 tests run, 1 failure, 707 skipped

Analysis:

  • Job ran for ~3 hours 24 minutes (13:04:54 - 16:29:27 UTC)
  • Same flaky test as seen in previous CI run (Job 59888076527)
  • Test: AppsResourceTest.post_trigger_app_200
  • Error: "Max retries exceeded polling for eventual assert" at line 452
  • Eventual consistency test that polls for app state after triggering
  • Multiple InterruptedException errors during test execution
  • Additional errors: "Failed to publish event" for WorkflowEventConsumer

Flaky test indicators:

  • Repeat failure - Same test failed in previous workflow run
  • Timeout-based assertion (polling with retries)
  • 7813 other tests passed
  • InterruptedException suggests thread interruption during long-running test
  • Event publishing failures indicate timing/async issues
  • Test waits for app to run after trigger - timing-dependent

Pattern: This test consistently fails after ~3+ hours of CI testing, suggesting:

  • Resource exhaustion or thread pool depletion
  • Async event system timing issues under load
  • Insufficient polling timeout/retries for CI environment

Details

Summary by failure type:

  1. Playwright (1 job) - Flaky E2E tests (browser crashes, timeouts)
  2. Maven PostgreSQL (1 job) - Infrastructure disk space
  3. Maven SonarCloud (1 job) - Flaky integration test (same test as previous run)

Unrelated to this PR's changes: This PR only modifies Data Insights retention configuration (7→90 days). All three failures are caused by:

  • Test flakiness (Playwright + Maven SonarCloud)
  • Infrastructure constraints (Maven PostgreSQL disk space)
Code Review 👍 Approved with suggestions

Straightforward configuration update changing Data Insights retention from 7 to 90 days across all relevant schema and config files.

Suggestions 💡 1 suggestion
Code Quality: Unrelated .gitignore change bundled with retention update

📄 .gitignore:9

The addition of _bmad/ to .gitignore appears unrelated to the Data Insights retention configuration update. This mixes unrelated changes in a single PR.

Impact: Makes the PR harder to review and understand, and can complicate git history and potential reverts.

Suggested fix: Consider separating this into its own commit or PR, or at minimum document why this change is included in the PR description.

Resolved ✅ 1 resolved
Code Quality: PR title says "90 days" but code changes to 30 days

📄 openmetadata-service/src/main/resources/json/data/app/DataInsightsApplication.json:21 📄 openmetadata-spec/src/main/resources/json/schema/entity/applications/configuration/internal/dataInsightsAppConfig.json:61
The PR title states "Update Data Insights Retention to 90 days" but the actual code changes update the retention value from 7 to 30 days across all configuration files.

This discrepancy could cause confusion during review, merge, and for anyone later reading the git history to understand what retention value was intended.

Suggested fix: Either:

  1. Update the PR title to "Update Data Insights Retention to 30 days" if 30 is the intended value, or
  2. Change the retention values in the code from 30 to 90 if 90 days is actually the desired retention period.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants