Skip to content

op/example fix warnings and error at compilation #13533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
+17 −18
Merged

op/example fix warnings and error at compilation #13533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ompi/mca/op/example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ do:
- `op_example_component.c`: The main "component" source file.
- `op_example_module.c`: The main "module" source file.
- `op_example.h`: information that is shared between the `.c` files.
- `.ompi_ignore`: the presence of this file causes OMPI's `autogen.pl`
- `.opal_ignore`: the presence of this file causes OMPI's `autogen.pl`
to skip this component in the configure/build/install process (see
below).

Expand All @@ -69,18 +69,18 @@ shell$ cp -r example foo
shell$ cd foo
```

Remove the `.ompi_ignore` file (which makes the component "visible" to
all developers) *OR* add an `.ompi_unignore` file with one username per
Remove the `.opal_ignore` file (which makes the component "visible" to
all developers) *OR* add an `.opal_unignore` file with one username per
line (as reported by `whoami`). OMPI's `autogen.pl` will skip any
component with a `.ompi_ignore` file *unless* there is also an
.ompi_unignore file containing your user ID in it. This is a handy
component with a `.opal_ignore` file *unless* there is also an
`.opal_unignore` file containing your user ID in it. This is a handy
mechanism to have a component in the tree but have it not built / used
by most other developers:

```
shell$ rm .ompi_ignore
shell$ rm .opal_ignore
*OR*
shell$ whoami > .ompi_unignore
shell$ whoami > .opal_unignore
```

Now rename any file that contains `example` in the filename to have
Expand Down
1 change: 0 additions & 1 deletion ompi/mca/op/example/op_example_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ static char *example_component_version;
*/
static int example_component_register(void)
{
int val;
char *str;

opal_output(ompi_op_base_framework.framework_output, "example component register");
Expand Down
12 changes: 6 additions & 6 deletions ompi/mca/op/example/op_example_module_bxor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static OBJ_CLASS_INSTANCE(module_bxor_t,
/**
* Bxor function for C int
*/
static void bxor_int(void *in, void *out, int *count,
static void bxor_int(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_bxor_t *m = (module_bxor_t*) module;
Expand Down Expand Up @@ -143,7 +143,7 @@ static void bxor_int(void *in, void *out, int *count,
/**
* Bxor function for C long
*/
static void bxor_long(void *in, void *out, int *count,
static void bxor_long(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_bxor_t *m = (module_bxor_t*) module;
Expand All @@ -157,7 +157,7 @@ static void bxor_long(void *in, void *out, int *count,
/**
* Bxor function for Fortran INTEGER
*/
static void bxor_integer(void *in, void *out, int *count,
static void bxor_integer(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_bxor_t *m = (module_bxor_t*) module;
Expand Down Expand Up @@ -191,10 +191,10 @@ ompi_op_base_module_t *ompi_op_example_setup_bxor(ompi_op_t *op)
(i.e., they're already assigned on the op). */

/* C int */
module->super.opm_fns[OMPI_OP_BASE_TYPE_INT] = bxor_int;
module->fallback_int = op->o_func.intrinsic.fns[OMPI_OP_BASE_TYPE_INT];
module->super.opm_fns[OMPI_OP_BASE_TYPE_INT32_T] = bxor_int;
module->fallback_int = op->o_func.intrinsic.fns[OMPI_OP_BASE_TYPE_INT32_T];
module->fallback_int_module =
op->o_func.intrinsic.modules[OMPI_OP_BASE_TYPE_INT];
op->o_func.intrinsic.modules[OMPI_OP_BASE_TYPE_INT32_T];
/* If you cache a fallback function, you *must* RETAIN (i.e.,
increase the refcount) its module so that the module knows that
it is being used and won't be freed/destructed. */
Expand Down
8 changes: 4 additions & 4 deletions ompi/mca/op/example/op_example_module_max.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ static OBJ_CLASS_INSTANCE(module_max_t,
/**
* Max function for C float
*/
static void max_float(void *in, void *out, int *count,
static void max_float(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_max_t *m = (module_max_t*) module;
Expand Down Expand Up @@ -152,7 +152,7 @@ static void max_float(void *in, void *out, int *count,
/**
* Max function for C double
*/
static void max_double(void *in, void *out, int *count,
static void max_double(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_max_t *m = (module_max_t*) module;
Expand All @@ -166,7 +166,7 @@ static void max_double(void *in, void *out, int *count,
/**
* Max function for Fortran REAL
*/
static void max_real(void *in, void *out, int *count,
static void max_real(const void *in, void *out, int *count,
ompi_datatype_t **type, ompi_op_base_module_t *module)
{
module_max_t *m = (module_max_t*) module;
Expand All @@ -180,7 +180,7 @@ static void max_real(void *in, void *out, int *count,
/**
* Max function for Fortran DOUBLE PRECISION
*/
static void max_double_precision(void *in, void *out, int *count,
static void max_double_precision(const void *in, void *out, int *count,
ompi_datatype_t **type,
ompi_op_base_module_t *module)
{
Expand Down