-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat: add ipv6 support #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ipv6 support #2594
Conversation
28m to build the I don't think it is related to the PR though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gnmeyer thanks for that, and sorry for taking that long to review the PR.
I was in the process of releasing a new version of the Demo and that took longer than expected.
After testing your PR locally and checking the code, I saw that we were missing a couple of stuff.
The services were checking IPV6_ENABLED
, but this env var wasn't set anywhere.
I've added it to the services you've changed and also added a control on the .env
file.
We need to add the IPV6_ENABLED
to the services on the file docker-compose.minimal.yml
, would you be able to take care of that?
Hey @julianocosta89, sounds good. I went ahead and added in those changes to the docker compose minimal file. Thanks for the review! |
Thanks for that @gnmeyer |
Changes
Modified the
currency
,shipping
,quote
, andpayment
services to support IPv6.Geared towards Kubernetes environments, so there is an associated change in the helm chart repo. (Link)
Link to issue
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.