Skip to content

Conversation

gnmeyer
Copy link
Contributor

@gnmeyer gnmeyer commented Sep 25, 2025

Changes

Modified the currency, shipping, quote, and payment services to support IPv6.

Geared towards Kubernetes environments, so there is an associated change in the helm chart repo. (Link)

Link to issue

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@gnmeyer gnmeyer requested a review from a team as a code owner September 25, 2025 21:22
Copy link

linux-foundation-easycla bot commented Sep 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Sep 25, 2025
@julianocosta89
Copy link
Member

28m to build the currency and counting 😢

I don't think it is related to the PR though

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gnmeyer thanks for that, and sorry for taking that long to review the PR.
I was in the process of releasing a new version of the Demo and that took longer than expected.

After testing your PR locally and checking the code, I saw that we were missing a couple of stuff.

The services were checking IPV6_ENABLED, but this env var wasn't set anywhere.
I've added it to the services you've changed and also added a control on the .env file.
We need to add the IPV6_ENABLED to the services on the file docker-compose.minimal.yml, would you be able to take care of that?

@gnmeyer
Copy link
Contributor Author

gnmeyer commented Oct 3, 2025

Hey @julianocosta89, sounds good. I went ahead and added in those changes to the docker compose minimal file. Thanks for the review!

@julianocosta89 julianocosta89 merged commit 4052f28 into open-telemetry:main Oct 13, 2025
33 checks passed
@julianocosta89
Copy link
Member

Thanks for that @gnmeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-update-required Requires an update to the Helm chart when released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants