Skip to content

Conversation

martincostello
Copy link
Member

Fixes #4725

Changes

Use the configuration binding source generator where available to avoid need to suppress native AoT warnings.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Use the configuration binding source generator where available to avoid need to suppress native AoT warnings.

Resolves open-telemetry#4725.
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.68%. Comparing base (e7a801e) to head (d2ebf07).
⚠️ Report is 32 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6587      +/-   ##
==========================================
+ Coverage   86.65%   86.68%   +0.02%     
==========================================
  Files         258      258              
  Lines       11910    11910              
==========================================
+ Hits        10321    10324       +3     
+ Misses       1589     1586       -3     
Flag Coverage Δ
unittests-Project-Experimental 86.55% <ø> (-0.08%) ⬇️
unittests-Project-Stable 86.51% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...try/Logs/ILogger/OpenTelemetryLoggingExtensions.cs 97.43% <ø> (ø)

... and 3 files with indirect coverage changes

@martincostello
Copy link
Member Author

Looks like this isn't as simple as "remove suppressions and turn on the binder source generator" - will need to do further investigation.

Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOT] Use Configuration binder source generator in .NET 8

1 participant