-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(ci): add semconv-update workflow for automatic updates #6750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(ci): add semconv-update workflow for automatic updates #6750
Conversation
…ow, add workflow dispatch
…nto ci-add-semconv-update-workflow
Added minor UX upgrades and changed cache key to one specific to semconvkit's usage, example here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not generate the migration documentation for the packge. #6248 needs a resolution and then automation to add that documentation needs to be added prior to being able to automate the generation in this manner.
@@ -4,24 +4,6 @@ | |||
|
|||
Create a `Version Release` issue to track the release process. | |||
|
|||
## Semantic Convention Generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be completely removed. We still need the option to generate the packages locally and that process should be documented. Additionally, the automated way of generating the package should be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted and updated!
…tion instructions" This reverts commit 8f84faa.
Looks like #6248 is merged, we should be good to go, let me know |
# │ │ │ │ │ | ||
# │ │ │ │ │ | ||
# * * * * * | ||
- cron: '30 1 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely don't need to run this every hour. Daily, maybe weekly should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be translated to Every day at 1:30AM UTC
? 🤔
We can definetly do weekly, though
- cron: '30 1 * * *' | |
- cron: '30 1 * * 0' |
Would be Every Sunday at 1:30AM UTC
Description
Why
Additional notes