feat(kube-stack): add kubelet service monitor #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehboub
force-pushed
the
feat/kubelet-servicemonitor
branch
from
caa18bd to
35df391
Compare
smehboub
force-pushed
the
feat/kubelet-servicemonitor
branch
3 times, most recently
from
35df391 to
544ea3f
Compare
|
Hello @jaronoff97 Could you review this PR if possible, please ? Thank you very much in avance. |
|
@smehboub IIRC kubelet does not have an associated service (this resulted in Prometheus operator managing their own endpoints slice for the kubelet) this is why we have a manual ScrapeConfig in the configuration for the kube-stack chart. Has this changed in a recent version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serviceMonitor to scrape kubelet metrics from :
/api/v1/nodes/${1}/proxy/metrics/cadvisor
/api/v1/nodes/${1}/proxy/metrics/probes