Remove the need to bump class version when indy advice is used #15258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Nov 10, 2025
Comment on lines
+149
to
+150
| boolean allowClassVersionChange = | ||
| config.getBoolean("otel.javaagent.experimental.allow-class-version-change", false); |
Contributor
Author
There was a problem hiding this comment.
for now left a flag for switching back to changing the class version, if there is no interest in keeping it could remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bumping class version to 1.7 so
invokedynamicinstruction could be used this PR introduces a more conservative approach. If class version supportsinvokedynamicwe'll add theinvokedynamicinstruction as we do now. If the class version does not supportinvokedynamicwe generate an helper class that contains theinvokedynamicinstruction in a static method and invoke that method viainvokestatic. This way we don't have to worry about jvm class file parsing being more strict for newer class versions or building the stack map etc.