Update errorprone

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributes.java

@@ -41,7 +41,7 @@ public AttributesBuilder toBuilder() {
     return new ArrayBackedAttributesBuilder(new ArrayList<>(data()));
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // entries are typed as Object[]
   @Override
   @Nullable
   public <T> T get(AttributeKey<T> key) {

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributesBuilder.java

@@ -48,7 +48,7 @@ public <T> AttributesBuilder put(AttributeKey<T> key, @Nullable T value) {
   }
 
   @Override
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings({"unchecked", "rawtypes"}) // using "put" method with raw type AttributeKey
   public AttributesBuilder putAll(Attributes attributes) {
     if (attributes == null) {
       return this;

api/all/src/main/java/io/opentelemetry/api/common/AttributesBuilder.java

@@ -111,7 +111,7 @@ default AttributesBuilder put(String key, String... value) {
    *
    * @return this Builder
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // cast to T
   default <T> AttributesBuilder put(AttributeKey<List<T>> key, T... value) {
     if (value == null) {
       return this;

api/all/src/main/java/io/opentelemetry/api/internal/ImmutableKeyValuePairs.java

@@ -71,7 +71,7 @@ public final Map<K, V> asMap() {
 
   /** Returns the value for the given {@code key}, or {@code null} if the key is not present. */
   @Nullable
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // data is typed as Object[]
   public final V get(K key) {
     if (key == null) {
       return null;
@@ -85,7 +85,7 @@ public final V get(K key) {
   }
 
   /** Iterates over all the key-value pairs of labels contained by this instance. */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // data is typed as Object[]
   public final void forEach(BiConsumer<? super K, ? super V> consumer) {
     if (consumer == null) {
       return;
@@ -150,7 +150,7 @@ private static void splitAndMerge(
    * Left source half is sourceArray[ beginIndex:middleIndex-1]. Right source half is sourceArray[
    * middleIndex:endIndex-1]. Result is targetArray[ beginIndex:endIndex-1].
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // sourceArray and targetArray is typed as Object[]
   private static <K> void merge(
       Object[] sourceArray,
       int beginIndex,
@@ -192,7 +192,7 @@ private static <K> int compareToNullSafe(
     return keyComparator.compare(key, pivotKey);
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // data is typed as Object[]
   private static <K> Object[] dedupe(Object[] data, Comparator<K> keyComparator) {
     Object previousKey = null;
     int size = 0;

api/all/src/main/java/io/opentelemetry/api/internal/IncubatingUtil.java

@@ -18,7 +18,7 @@
 public class IncubatingUtil {
   private IncubatingUtil() {}
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // casting to T
   public static <T> T incubatingApiIfAvailable(T stableApi, String incubatingClassName) {
     try {
       Class<?> incubatingClass = Class.forName(incubatingClassName);

api/all/src/main/java/io/opentelemetry/api/internal/ReadOnlyArrayMap.java

@@ -37,7 +37,7 @@
  * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
  * at any time.
  */
-@SuppressWarnings("unchecked")
+@SuppressWarnings("unchecked") // array is typed as List<Object>
 public final class ReadOnlyArrayMap<K, V> extends AbstractMap<K, V> {
 
   /** Returns a read-only view of the given {@code array}. */

api/all/src/main/java/io/opentelemetry/api/logs/LogRecordBuilder.java

@@ -94,7 +94,7 @@ default LogRecordBuilder setBody(Value<?> body) {
    * Sets attributes. If the {@link LogRecordBuilder} previously contained a mapping for any of the
    * keys, the old values are replaced by the specified values.
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw AttributeKey
   default LogRecordBuilder setAllAttributes(Attributes attributes) {
     if (attributes == null || attributes.isEmpty()) {
       return this;

api/all/src/main/java/io/opentelemetry/api/trace/ArrayBasedTraceState.java

@@ -54,7 +54,7 @@ public void forEach(BiConsumer<String, String> consumer) {
   }
 
   @Override
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings({"unchecked", "rawtypes"}) // wrap takes List<Object>
   public Map<String, String> asMap() {
     return ReadOnlyArrayMap.wrap((List) getEntries());
   }

api/all/src/main/java/io/opentelemetry/api/trace/Span.java

@@ -180,7 +180,7 @@ default Span setAttribute(AttributeKey<Long> key, int value) {
    * @return this.
    * @since 1.2.0
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw AttributeKey
   default Span setAllAttributes(Attributes attributes) {
     if (attributes == null || attributes.isEmpty()) {
       return this;

api/all/src/main/java/io/opentelemetry/api/trace/SpanBuilder.java

@@ -259,7 +259,7 @@ default SpanBuilder setAttribute(AttributeKey<Long> key, int value) {
    * @return this.
    * @since 1.2.0
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw AttributeKey
   default SpanBuilder setAllAttributes(Attributes attributes) {
     if (attributes == null || attributes.isEmpty()) {
       return this;

api/incubator/src/main/java/io/opentelemetry/api/incubator/common/ArrayBackedExtendedAttributes.java

@@ -47,14 +47,14 @@ public ExtendedAttributesBuilder toBuilder() {
     return new ArrayBackedExtendedAttributesBuilder(new ArrayList<>(data()));
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // cast to T
   @Override
   @Nullable
   public <T> T get(ExtendedAttributeKey<T> key) {
     return (T) super.get(key);
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw ExtendedAttributeKey
   @Override
   public Attributes asAttributes() {
     if (attributes == null) {

api/incubator/src/main/java/io/opentelemetry/api/incubator/common/ExtendedAttributesBuilder.java

@@ -117,7 +117,7 @@ default ExtendedAttributesBuilder put(String key, String... value) {
    *
    * @return this Builder
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw AttributeKey
   default <T> ExtendedAttributesBuilder put(AttributeKey<List<T>> key, T... value) {
     if (value == null) {
       return this;

api/incubator/src/main/java/io/opentelemetry/api/incubator/logs/ExtendedLogRecordBuilder.java

@@ -79,7 +79,7 @@ default ExtendedLogRecordBuilder setBody(Value<?> body) {
    * log record, there is no difference between adding attributes using the standard or extended
    * attribute APIs.
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw AttributeKey
   @Override
   default ExtendedLogRecordBuilder setAllAttributes(Attributes attributes) {
     if (attributes == null || attributes.isEmpty()) {
@@ -100,7 +100,7 @@ default ExtendedLogRecordBuilder setAllAttributes(Attributes attributes) {
    * log record, there is no difference between adding attributes using the standard or extended
    * attribute APIs.
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // use of raw ExtendedAttributeKey
   default ExtendedLogRecordBuilder setAllAttributes(ExtendedAttributes attributes) {
     if (attributes == null || attributes.isEmpty()) {
       return this;

context/src/main/java/io/opentelemetry/context/ArrayBasedContext.java

@@ -56,7 +56,7 @@ private ArrayBasedContext(Object[] entries) {
   public <V> V get(ContextKey<V> key) {
     for (int i = 0; i < entries.length; i += 2) {
       if (entries[i] == key) {
-        @SuppressWarnings("unchecked")
+        @SuppressWarnings("unchecked") // entries are typed as Object[]
         V result = (V) entries[i + 1];
         return result;
       }

context/src/main/java/io/opentelemetry/context/internal/shaded/WeakConcurrentMap.java

@@ -135,7 +135,7 @@ public WeakConcurrentMap(
   }
 
   @Override
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // safe cast to LookupKey<K>
   protected LookupKey<K> getLookupKey(K key) {
     LookupKey<K> lookupKey;
     if (reuseKeys) {

dependencyManagement/build.gradle.kts

@@ -9,7 +9,7 @@ rootProject.extra["versions"] = dependencyVersions
 
 
 val autoValueVersion = "1.11.1"
-val errorProneVersion = "2.43.0"
+val errorProneVersion = "2.44.0"
 val jmhVersion = "1.37"
 // Mockito 5.x.x requires Java 11 https://github.com/mockito/mockito/releases/tag/v5.0.0
 val mockitoVersion = "4.11.0"

exporters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/MarshalerContext.java

@@ -138,15 +138,15 @@ void reset() {
   private final Pool<Map<?, ?>> mapPool = new Pool<>(IdentityHashMap::new, Map::clear);
 
   /** Returns a pooled identity map. */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // generic K,V
   public <K, V> Map<K, V> getIdentityMap() {
     return (Map<K, V>) mapPool.get();
   }
 
   private final Pool<List<?>> listPool = new Pool<>(ArrayList::new, List::clear);
 
   /** Returns a pooled list. */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // generic T
   public <T> List<T> getList() {
     return (List<T>) listPool.get();
   }
@@ -220,7 +220,7 @@ public static Key key() {
 
   private Object[] instances = new Object[16];
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // cast to generic T
   public <T> T getInstance(Key key, Supplier<T> supplier) {
     if (key.index >= instances.length) {
       Object[] newData = new Object[instances.length * 2];

exporters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/Serializer.java

@@ -518,7 +518,7 @@ public abstract <T> void serializeRepeatedMessageWithContext(
    * together with {@link StatelessMarshalerUtil#sizeRepeatedMessageWithContext(ProtoFieldInfo,
    * Collection, StatelessMarshaler, MarshalerContext, MarshalerContext.Key)}.
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // cast to List<T>
   public <T> void serializeRepeatedMessageWithContext(
       ProtoFieldInfo field,
       Collection<? extends T> messages,

exporters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/StatelessMarshalerUtil.java

@@ -144,7 +144,7 @@ public static <T> int sizeRepeatedMessageWithContext(
    * together with {@link Serializer#serializeRepeatedMessageWithContext(ProtoFieldInfo, Collection,
    * StatelessMarshaler, MarshalerContext, MarshalerContext.Key)}.
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // safe cast to List<T>
   public static <T> int sizeRepeatedMessageWithContext(
       ProtoFieldInfo field,
       Collection<? extends T> messages,

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AnyValueMarshaler.java

@@ -21,7 +21,7 @@ public final class AnyValueMarshaler {
 
   private AnyValueMarshaler() {}
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by discriminated type
   public static MarshalerWithSize create(Value<?> value) {
     switch (value.getType()) {
       case STRING:

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AnyValueStatelessMarshaler.java

@@ -27,7 +27,7 @@ public final class AnyValueStatelessMarshaler implements StatelessMarshaler<Valu
 
   private AnyValueStatelessMarshaler() {}
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by discriminated type
   @Override
   public void writeTo(Serializer output, Value<?> value, MarshalerContext context)
       throws IOException {
@@ -71,7 +71,7 @@ public void writeTo(Serializer output, Value<?> value, MarshalerContext context)
     throw new IllegalArgumentException("Unsupported value type.");
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by discriminated type
   @Override
   public int getBinarySerializedSize(Value<?> value, MarshalerContext context) {
     switch (value.getType()) {

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AttributeArrayAnyValueStatelessMarshaler.java

@@ -22,7 +22,7 @@ final class AttributeArrayAnyValueStatelessMarshaler<T>
 
   private AttributeArrayAnyValueStatelessMarshaler() {}
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by discriminated type
   @Override
   public void writeTo(Serializer output, AttributeType type, List<T> list, MarshalerContext context)
       throws IOException {
@@ -57,7 +57,7 @@ public void writeTo(Serializer output, AttributeType type, List<T> list, Marshal
     }
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by discriminated type
   @Override
   public int getBinarySerializedSize(AttributeType type, List<T> list, MarshalerContext context) {
     switch (type) {

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AttributeKeyValue.java

@@ -32,7 +32,7 @@ static <T> AttributeKeyValue<T> of(AttributeKey<T> attributeKey, T value) {
   }
 
   /** Returns a List corresponding to the provided Map. This is a copy, not a view. */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe as we are just iterating over the map entries
   static <T> List<AttributeKeyValue<?>> of(Attributes attributes) {
     List<AttributeKeyValue<?>> result = new ArrayList<>(attributes.size());
     attributes.forEach(

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AttributeKeyValueStatelessMarshaler.java

@@ -72,7 +72,7 @@ private static class ValueStatelessMarshaler
       implements StatelessMarshaler2<AttributeKey<?>, Object> {
     static final ValueStatelessMarshaler INSTANCE = new ValueStatelessMarshaler();
 
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked") // Safe by discriminated type
     @Override
     public int getBinarySerializedSize(
         AttributeKey<?> attributeKey, Object value, MarshalerContext context) {
@@ -106,7 +106,7 @@ public int getBinarySerializedSize(
       throw new IllegalArgumentException("Unsupported attribute type.");
     }
 
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked") // Safe by discriminated type
     @Override
     public void writeTo(
         Serializer output, AttributeKey<?> attributeKey, Object value, MarshalerContext context)

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/ExtendedAttributeKeyValueStatelessMarshaler.java

@@ -140,7 +140,7 @@ private static class ValueStatelessMarshaler
       implements StatelessMarshaler2<ExtendedAttributeKey<?>, Object> {
     static final ValueStatelessMarshaler INSTANCE = new ValueStatelessMarshaler();
 
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked") // Safe by discriminated type
     @Override
     public int getBinarySerializedSize(
         ExtendedAttributeKey<?> attributeKey, Object value, MarshalerContext context) {
@@ -180,7 +180,7 @@ public int getBinarySerializedSize(
       throw new IllegalArgumentException("Unsupported attribute type.");
     }
 
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings("unchecked") // Safe by discriminated type
     @Override
     public void writeTo(
         Serializer output,

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/IncubatingUtil.java

@@ -80,7 +80,7 @@ public void accept(ExtendedAttributeKey<?> attributeKey, Object o) {
   }
 
   // TODO(jack-berg): move to KeyValueMarshaler when ExtendedAttributes is stable
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // casting to specific types based on attributeKey type
   private static KeyValueMarshaler create(ExtendedAttributeKey<?> attributeKey, Object value) {
     byte[] keyUtf8;
     if (attributeKey.getKey().isEmpty()) {

exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/KeyValueMarshaler.java

@@ -88,7 +88,7 @@ public void accept(AttributeKeyValue<?> attributeKeyValue) {
     return keyValueMarshalers;
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe by disriminated type
   private static KeyValueMarshaler create(AttributeKey<?> attributeKey, Object value) {
     byte[] keyUtf8;
     if (attributeKey.getKey().isEmpty()) {

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java

@@ -1202,7 +1202,7 @@ private List<U> toProto(List<T> telemetry) {
               ByteArrayOutputStream bos = new ByteArrayOutputStream();
               try {
                 marshaler.writeBinaryTo(bos);
-                @SuppressWarnings("unchecked")
+                @SuppressWarnings("unchecked") // cast to U
                 U result =
                     (U)
                         resourceTelemetryInstance

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java

@@ -1090,7 +1090,7 @@ private List<U> toProto(List<T> telemetry) {
               ByteArrayOutputStream bos = new ByteArrayOutputStream();
               try {
                 marshaler.writeBinaryTo(bos);
-                @SuppressWarnings("unchecked")
+                @SuppressWarnings("unchecked") // safe cast to U
                 U result =
                     (U)
                         resourceTelemetryInstance

opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java

@@ -186,7 +186,7 @@ public SpanBuilder withStartTimestamp(long microseconds) {
     return this;
   }
 
-  @SuppressWarnings({"rawtypes", "unchecked"})
+  @SuppressWarnings({"rawtypes", "unchecked"}) // use of raw AttributeKey
   @Override
   public Span start() {
     Baggage baggage;

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributeListFactory.java

@@ -119,7 +119,7 @@ private static void addToBuilder(
             + type.name());
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // safe due to type check
   @Nullable
   private static <T> List<T> checkListOfType(Object value, Class<T> expectedType) {
     if (!(value instanceof List)) {

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/YamlDeclarativeConfigProperties.java

@@ -73,7 +73,7 @@ private YamlDeclarativeConfigProperties(
    *
    * @see DeclarativeConfiguration#toConfigProperties(Object)
    */
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe due to type checks
   public static YamlDeclarativeConfigProperties create(
       Map<String, Object> properties, ComponentLoader componentLoader) {
     Map<String, Object> simpleEntries = new LinkedHashMap<>();
@@ -192,7 +192,7 @@ public Double getDouble(String name) {
 
   @Nullable
   @Override
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings("unchecked") // Safe due to type check
   public <T> List<T> getScalarList(String name, Class<T> scalarType) {
     if (!SUPPORTED_SCALAR_TYPES.contains(scalarType)) {
       throw new DeclarativeConfigException(