refactor(opentelemetry-core): simplify parsePairKeyValue()

[sivakumarsc]

Which problem is this PR solving?

While analysing our application CPU profile, we found parsePairKeyValue from @opentelemetry/core is one of the hot function.

Fixes # (issue)

Short description of the changes

Refactor the parsePairKeyValue function to simplify the computations

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

A Benchmark test to compare the Older and newer implementation

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: david-luna / name: David Luna (297814f, bf75d7f)
• ✅ login: sivakumarsc / name: Sivakumar (06bc965, 2885a0b, 3240b06, 36b3d65, 63346fc, 6b5eab8, 8064a0e, ce02a96, d2120eb, e8085de, 9de69b8, e074d7f)

[codecov]

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.06%. Comparing base (52ffa04) to head (e8085de).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/opentelemetry-core/src/baggage/utils.ts	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5885      +/-   ##
==========================================
- Coverage   95.06%   95.06%   -0.01%     
==========================================
  Files         307      307              
  Lines        8031     8038       +7     
  Branches     1627     1629       +2     
==========================================
+ Hits         7635     7641       +6     
- Misses        396      397       +1     

Files with missing lines	Coverage Δ
packages/opentelemetry-core/src/baggage/utils.ts	97.61% <93.33%> (-2.39%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[trentm]

I haven't dug into why yet, but the new impl shows to be the same time or slower for me:

[15:39:10 trentm@peach:~/tm/opentelemetry-js4/packages/opentelemetry-core (git:refactor-parse-pair-key-value)]
% npm run test:bench

> @opentelemetry/core@2.0.1 test:bench
> node test/performance/benchmark/index.js

parsePairKeyValue simple (old) x 5,054,037 ops/sec ±0.67% (93 runs sampled)
parsePairKeyValue simple (new) x 5,039,987 ops/sec ±0.68% (95 runs sampled)
parsePairKeyValue with metadata (old) x 4,525,204 ops/sec ±0.69% (92 runs sampled)
parsePairKeyValue with metadata (new) x 4,346,512 ops/sec ±0.58% (92 runs sampled)
parsePairKeyValue URI encoded (old) x 4,430,196 ops/sec ±0.62% (96 runs sampled)
parsePairKeyValue URI encoded (new) x 4,435,236 ops/sec ±0.61% (96 runs sampled)
parsePairKeyValue complex (old) x 3,606,884 ops/sec ±0.71% (93 runs sampled)
parsePairKeyValue complex (new) x 3,496,362 ops/sec ±0.70% (97 runs sampled)
[15:40:01 trentm@peach:~/tm/opentelemetry-js4/packages/opentelemetry-core (git:refactor-parse-pair-key-value)]
% node --version
v20.19.1

Similar on Node.js 24:

% node --version
v24.6.0
[15:41:22 trentm@peach:~/tm/opentelemetry-js4/packages/opentelemetry-core (n:24 git:refactor-parse-pair-key-value)]
% npm run test:bench

> @opentelemetry/core@2.0.1 test:bench
> node test/performance/benchmark/index.js

parsePairKeyValue simple (old) x 5,442,733 ops/sec ±0.74% (95 runs sampled)
parsePairKeyValue simple (new) x 5,459,702 ops/sec ±0.85% (95 runs sampled)
parsePairKeyValue with metadata (old) x 4,800,913 ops/sec ±0.70% (93 runs sampled)
parsePairKeyValue with metadata (new) x 4,682,423 ops/sec ±0.76% (94 runs sampled)
parsePairKeyValue URI encoded (old) x 4,505,672 ops/sec ±0.66% (94 runs sampled)
parsePairKeyValue URI encoded (new) x 4,530,546 ops/sec ±0.95% (89 runs sampled)
parsePairKeyValue complex (old) x 3,611,070 ops/sec ±0.98% (95 runs sampled)
parsePairKeyValue complex (new) x 3,680,629 ops/sec ±0.74% (96 runs sampled)

FWIW: This is on macos 15.6.1, arm64.

[sivakumarsc]

npm run test:bench

Not sure, why you are seeing different numbers with the same config.

My machine - MacOs - 15.6.1, Mac M3 pro

Node 20.11.1

Node 24.6.0

[david-luna]

my results are

for node v20.19.1

npm run test:bench

> @opentelemetry/core@2.1.0 test:bench
> node test/performance/benchmark/index.js

parsePairKeyValue simple (old) x 4,692,843 ops/sec ±0.41% (94 runs sampled)
parsePairKeyValue simple (new) x 6,267,494 ops/sec ±0.32% (97 runs sampled)
parsePairKeyValue with metadata (old) x 4,180,132 ops/sec ±0.32% (97 runs sampled)
parsePairKeyValue with metadata (new) x 5,656,792 ops/sec ±0.33% (100 runs sampled)
parsePairKeyValue URI encoded (old) x 4,116,159 ops/sec ±1.15% (98 runs sampled)
parsePairKeyValue URI encoded (new) x 5,144,204 ops/sec ±0.55% (99 runs sampled)
parsePairKeyValue complex (old) x 3,226,162 ops/sec ±0.28% (99 runs sampled)
parsePairKeyValue complex (new) x 4,714,852 ops/sec ±0.27% (99 runs sampled)

node --version
v20.19.1

for node v24.0.2

npm run test:bench

> @opentelemetry/core@2.1.0 test:bench
> node test/performance/benchmark/index.js

parsePairKeyValue simple (old) x 4,786,133 ops/sec ±0.34% (99 runs sampled)
parsePairKeyValue simple (new) x 5,645,059 ops/sec ±0.29% (97 runs sampled)
parsePairKeyValue with metadata (old) x 4,332,720 ops/sec ±0.35% (100 runs sampled)
parsePairKeyValue with metadata (new) x 4,920,477 ops/sec ±0.34% (96 runs sampled)
parsePairKeyValue URI encoded (old) x 4,149,403 ops/sec ±0.30% (97 runs sampled)
parsePairKeyValue URI encoded (new) x 4,647,395 ops/sec ±0.42% (100 runs sampled)
parsePairKeyValue complex (old) x 3,416,122 ops/sec ±0.33% (99 runs sampled)
parsePairKeyValue complex (new) x 4,128,169 ops/sec ±0.33% (98 runs sampled)

node --version
v24.0.2

This is on MacOS 15.7.1 with M2 chip. Could it be related to the chip?

[sivakumarsc]

@david-luna Not sure if this due to chip. But for me refactored function always shows better runtime.