Skip to content

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Follow-up to #5928, as I missed it while doing the review. I noticed this while working on #5994.

The userAgent option is not used in any of the browser transports. This PR removes it from the OtlpHttpConfiguration interface so that it's only present on OtlpNodeHttpConfiguration and OtlpGrpcConfiguration where it's actually used. 🙂

Skipping changelog since the change from #5928 is unreleased.

cc @david-luna

@pichlermarc pichlermarc requested a review from a team as a code owner October 14, 2025 13:00
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.23%. Comparing base (fe18523) to head (637aeea).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6013   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         311      311           
  Lines        8597     8597           
  Branches     1801     1801           
=======================================
  Hits         8187     8187           
  Misses        410      410           
Files with missing lines Coverage Δ
...-base/src/configuration/otlp-http-configuration.ts 100.00% <ø> (ø)
.../src/configuration/otlp-node-http-configuration.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc changed the title fix(otlp-exporter-base): avoid adding new User-Agent option for browser fix(otlp-exporter-base): avoid adding new userAgent option for browser Oct 14, 2025
@pichlermarc pichlermarc changed the title fix(otlp-exporter-base): avoid adding new userAgent option for browser fix(otlp-exporter-base): avoid adding new userAgent option for browser exporters Oct 14, 2025
Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, is not needed for now. But IIUC we may need to review this if we want to remove the legacy options :) I got a bit lost navigating the interfaces 😅

@david-luna david-luna added this pull request to the merge queue Oct 15, 2025
Merged via the queue into open-telemetry:main with commit deced49 Oct 15, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants