Prevent recursive logging issue in SimpleLogRecordProcessor.on_emit
#4799
+93
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanRussell
changed the title
DylanRussell
changed the title
SimpleLogRecordProcessor.on_emit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent recursive logging issues in
SimpleLogRecordProcessor.on_emitby inspecting the stack trace to see how many times it's been called. Stop logging when we hit a recursive depth of 4.. This way we let through some logs through --- it may be the exporter has a transient log it is sending -- but stop when there's probably a recursive loop occurring.I also reverted / cleaned up the changes I made in #4588. Looking at #4585 again -- the recursion issue is in the
SimpleLogRecordProcessornot in theBatchLogRecordProcessor-- I think the batch processor should be safe from recursion because it is sending batches on a different thread periodically and not via a synchronous blocking call...Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: