-
Notifications
You must be signed in to change notification settings - Fork 933
OTEP: Recording exceptions as log records #4333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think this is a related issue: |
b06a09f to
76c7d85
Compare
1a1ea49 to
5ddfd05
Compare
db27087 to
e9f38aa
Compare
|
A small doubt:
Although (I think) it's not called out, I'm understanding exceptions should now be explicitly reported as both 1) Span.Event and 2) Log/Event? i.e. coding wise you should do this: currentSpan.recordException(e);
logger.logRecordBuilder
.addException(e);Is this the case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm very supportive. Just some nits and one mitigation I'd like to see called out/addressed.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
db2b647 to
0b361ca
Compare
e030736 to
0be3bc3
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
| This OTEP continues [Span Event API deprecation plan OTEP](./4430-span-event-api-deprecation-plan.md) | ||
| and provides guidance on how to record errors and exceptions using OpenTelemetry Logs, | ||
| focusing on minimizing duplication and providing context to reduce noise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran across another benefit, as it will allow users to capture all exceptions (if they want) even when doing sampling on traces.
|
Related to open-telemetry/semantic-conventions#1536
Changes
Recording exceptions as span events is problematic since it
This OTEP provides guidance on how to record exceptions using OpenTelemetry logs focusing on minimizing duplication and providing context to reduce the noise.
If accepted, the follow-up spec changes are expected to replace existing (stable) documents:
Related OTEP(s) #CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary