fix(meta): handle 429 (rate limit) gracefully #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Every provider has a different error format which we don't really have a unified parsing mechanism for. However all major players in the scene agree that an HTTP 429 is a rate limit, so we can leverage that. During #643 I believe I missed the non-OpenAI rate limit errors as no direct HTTP status code checking occurs (with exception of a few cases).
This means a rate limit bubbles through to an ErrorException (in case of OpenAI) or in case of another provider - goes onward to the concrete class and crashes.
This adds a tiny check for only HTTP 429 as the payload structure is wildly different between all providers. Userland implementations can use the exception (for backoff/retries) and dig into the include Response for more in-depth handling.
Related:
fixes: #587