fix: preserve arg0 for PTY sandbox commands without relying on PATH #7596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified exec PTY sessions under Seccomp were using arg0 as the program when spawning the PTY. For the
codex-linux-sandboxcase, this meant we were actually executing codex-linux-sandbox viaPATHlookup instead of the configuredcodex_linux_sandbox_exepath.Fix:
On Unix, creates a temporary directory, symlinks the real program to a filename derived from arg0 (i.e.
codex-linux-sandbox), and uses that symlink as the command in CommandBuilder.This preserves argv[0] for dispatch while always executing the configured program path, and falls back to the old behavior when program is not absolute or arg0 is unset.