Fix unified_exec on windows #7620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jif-oai
reviewed
Dec 5, 2025
| } | ||
| }; | ||
| skip_if_sandbox!(Ok(())); | ||
| skip_if!(cfg!(target_os = "windows"), Ok(())); |
Collaborator
There was a problem hiding this comment.
Why skipping windows on this one?
codex-rs/utils/pty/src/lib.rs
Outdated
| use tokio::sync::Mutex as TokioMutex; | ||
| use tokio::task::JoinHandle; | ||
|
|
||
| #[allow(dead_code)] |
Collaborator
There was a problem hiding this comment.
To suppress the unused field error.
jif-oai
approved these changes
Dec 5, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Once the test are fixed and based on Slack explainations
# Conflicts: # codex-rs/core/tests/common/lib.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unified_exec on windows
Requires removal of PSUEDOCONSOLE_INHERIT_CURSOR flag so child processed don't attempt to wait for cursor position response (and timeout).
https://github.com/wezterm/wezterm/compare/main...pakrym:wezterm:PSUEDOCONSOLE_INHERIT_CURSOR?expand=1