feat: replace reflections lib with classgraph #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. I am not using the plugin in my daily work anymore but I'll try to find the time to create a new release as soon as possible. |
|
Hi @langecode, Sorry to bother you again. Just wondering whether I need to create the new release myself (for use by collaborators) or do you have a rough idea, when you have time to look at this and potentially create a new official release? |
CarstenWickner
force-pushed
the
master
branch
2 times, most recently
from
a91604a to
e51670a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reflectionslibrary is no longer maintained. There is no point in employing workarounds to the "SubTypesScanner not found issue" (for reference, one would have to build thereflectionsdifferently like here).Instead, do the same as other libraries do: move to
classgraphinstead.It's faster, still being maintained, and doesn't have this annoying bug.
Extra upside: no need to change the context classloader.
classgraphhas a more explicit classloader handling thanreflections.This fixes #96.