Skip to content

Conversation

priya-tik
Copy link
Contributor

This PR adds missing cancel functionality to the Group Details wizard modal. Previously, the cancel button was non-functional due to the absence of a callback handler. This update ensures a smooth user experience by allowing users to exit the modal properly.

Copy link
Contributor

github-actions bot commented May 8, 2025

Hi @priya-tik
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented May 8, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1204

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1204

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented May 8, 2025

This pull request is deployed at test.admin-interface.opencast.org/1204/2025-05-17_06-36-28/ .
It might take a few minutes for it to become available.

@priya-tik priya-tik changed the title Fix group cancel button Fix group cancel button#1182 May 8, 2025
@priya-tik priya-tik changed the title Fix group cancel button#1182 Fix group cancel button May 8, 2025
@priya-tik
Copy link
Contributor Author

@Arnei Please add the bug or enhancement labels to this PR. Thank you!

@Arnei Arnei added type:bug Something isn't working priority:low labels May 8, 2025
@Piriya-VM Piriya-VM self-requested a review May 13, 2025 09:46
Copy link
Contributor

@Piriya-VM Piriya-VM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cancel button works now. :) I didn't do a code review!

@NadiaUoM
Copy link
Contributor

This PR commits content the fix for below PR's as well:

#1200
#1197

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@lkiesow
Copy link
Member

lkiesow commented May 15, 2025

Apart from this having conflicts, it's very confusing that you created multiple pull requests all with the same code.
Can you split them apart and create one pull request for one patch, please?
It's basically creating a new branch per pull request and then using that to create the pull request.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@NadiaUoM
Copy link
Contributor

@Arnei : I think we should close this PR also since the changes for this issue has been already merged...

#1277

@Arnei
Copy link
Member

Arnei commented May 21, 2025

Seems so, closing this. Still, thanks for working on this priya-tik!

@Arnei Arnei closed this May 21, 2025
@priya-tik priya-tik deleted the fix-group-cancel-button branch May 21, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants