Skip to content

Reduce duplicate code in filter cell #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Reduce duplicate code in filter cell #1367

wants to merge 3 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 10, 2025

Some cells in a table set a filter when their content is clicked. This adds a component for these types of cells.

Also removes an unused component.

How to test

Can be tested as usual. Should result in no functional changes.

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jul 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1367

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1367

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1367/2025-07-10_12-02-29/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the reduce-duplicate-code-filtercells branch from d01d426 to e7017e7 Compare July 11, 2025 11:36
@Arnei Arnei force-pushed the reduce-duplicate-code-filtercells branch from e7017e7 to 8478e6a Compare July 11, 2025 11:39
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the reduce-duplicate-code-filtercells branch from 8478e6a to 511c605 Compare July 14, 2025 07:58
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei
Reduce duplicate code in filter cell
bebc40a 
Some cells in a table set a filter when their content is clicked.
This adds a component for these types of cells.

Also removes an unused component.
@Arnei Arnei force-pushed the reduce-duplicate-code-filtercells branch from 511c605 to bebc40a Compare July 14, 2025 11:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei changed the base branch from develop to r/18.x August 11, 2025 07:42
@Arnei Arnei changed the base branch from r/18.x to develop August 11, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei