Skip to content

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 10, 2025

Adds a single main page component, so pages don't have to import the different headers and footer again and again. Also adds a table page component, since almost all of our pages are just a big table.

Can be tested as usual, should result in no functional changes.

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jul 10, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1369

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1369

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1369/2025-07-10_14-55-34/ .
It might take a few minutes for it to become available.

Copy link
Member

@gregorydlogan gregorydlogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~Doesn't build, likely from changes in #1347 ~

This was caused by #1371, just ignore me...

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Adds a single main page component, so pages don't
have to import the different headers and footer again and again.
Also adds a table page component, since almost all of our
pages are just a big table.
@Arnei Arnei force-pushed the reduce-duplicate-code-tablepage branch from 4f90524 to 87386cc Compare July 14, 2025 11:51
@Arnei Arnei changed the base branch from develop to r/18.x August 11, 2025 07:42
@gregorydlogan gregorydlogan self-assigned this Aug 25, 2025
@gregorydlogan gregorydlogan merged commit e24c7a1 into opencast:r/18.x Aug 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants