Skip to content

Fix ACL role dropdown width #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 11, 2025

The role dropdown in the ACL tabs could extend over its column width, due to its own fixed width. This fixes that.

Replaces #1365

@Arnei Arnei added the type:bug Something isn't working label Jul 11, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1370

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1370

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@wsmirnow wsmirnow self-assigned this Jul 14, 2025
Copy link
Contributor

@wsmirnow wsmirnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event and series details dialog works now as expected. But new event and new series dialog is not fixed.

image

Organization > Access policies > Add access policy and details dialog is broken too.

@Arnei can you fix it please?

@Arnei
Copy link
Member Author

Arnei commented Jul 14, 2025

The new event/series/acl dialogs look fine to me. Can't yet think of reason why it is different for you.

Bildschirmfoto vom 2025-07-14 14-10-20

@gregorydlogan
Copy link
Member

I can reproduce Waldemar's experience, even after clearing my cache.

@Arnei Arnei force-pushed the acl-role-dropdown-width-17 branch from 1f47e90 to f25cd45 Compare July 23, 2025 13:26
@Arnei
Copy link
Member Author

Arnei commented Jul 23, 2025

@wsmirnow Helped me fix my confusion, thanks for that. Should now also properly work for in the New Event/Series/Acl modal and the Acl Details modal.

The role dropdown in the ACL tabs could extend over its column width, due to its own fixed width.
This fixes that.
@Arnei Arnei force-pushed the acl-role-dropdown-width-17 branch from f25cd45 to f5f5c36 Compare July 24, 2025 08:13
Copy link
Contributor

@wsmirnow wsmirnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thank you @Arnei

@Arnei Arnei merged commit 27273db into opencast:r/17.x Jul 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants