feat(service): Add substations service, fix typing #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsjc
commented
Dec 3, 2025
braddf
requested changes
Dec 3, 2025
Contributor
braddf
left a comment
braddf
left a comment
There was a problem hiding this comment.
LGTM! 👍 Requesting changes for addressing these few comments but some/all might just be replies/explanations, not code changes.
7 tasks
devsjc
force-pushed
the
devsjc/ukpn-routes
branch
from
79cf32c to
9aba918
Compare
devsjc
commented
Dec 5, 2025
devsjc
force-pushed
the
devsjc/ukpn-routes
branch
2 times, most recently
from
f4372f7 to
0497a8c
Compare
devsjc
changed the title
devsjc
changed the title
devsjc
force-pushed
the
devsjc/ukpn-routes
branch
from
0497a8c to
9acdc23
Compare
devsjc
force-pushed
the
devsjc/ukpn-routes
branch
from
9422735 to
9cff15c
Compare
peterdudfield
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
substationsservice to interact with substations in the data platform.Also corrects some typing issues, and fixes an async bug with the data platform backend.
Modifies the way the app is configured through the environment. See
server.conffor new env vars.