feat: add ability to get individual controller stats #53
+1,138
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
f8a0dd5 to
7c07d8a
Compare
Author
|
Hi @kolyshkin |
Author
|
Hi @haircommander |
fs/fs.go
Outdated
| return stats, nil | ||
| } | ||
|
|
||
| func (m *Manager) GetCpuStats() (*cgroups.Stats, error) { |
Contributor
There was a problem hiding this comment.
maybe call these Add*Stats and have them take a stats object, so we can iteratively populate rather than needing to merge later
Author
There was a problem hiding this comment.
Makes sense.
I have refactored all to Add*Stats.
Contributor
|
would love to see some unit tests, and maybe even a POC of it being used in an end user project like CRI-O |
Author
I have added the unit tests
I'm not very familiar with codebase of CRI-O, but I can get a quick POC in |
This adds methods to retrieve statistics for individual cgroup controllers (CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all stats to be fetched at once. This enables tools like cadvisor to collect specific metrics with different housekeeping intervals, reducing computational overhead. Fixes: opencontainers#44 Signed-off-by: Sambhav Jain <jnsmbhv@gmail.com>
Contributor
|
LGTM thank you! |
Author
|
@haircommander metrics output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add methods to retrieve statistics for individual cgroup controllers
(CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all
stats to be fetched at once.
Fixes: #44