Fix invalid variable name in bash completion script #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcing completions/bash/oci-image-tool produces:
bash: __oci-image-tool_previous_extglob_setting=shopt: command not found
bash: eval: -i: invalid option
eval: usage: eval [arg ...]
This occurs because `__oci-image-tool_previous_extglob_setting` is not a
valid variable name (see https://unix.stackexchange.com/q/23659).
Fix the variable name by replacing `-` with `_`. Since the variable is
unset before the script finishes, this presents minimal compatibility
risk.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourcing
completions/bash/oci-image-toolin bash produces:This occurs because
__oci-image-tool_previous_extglob_settingis not a valid variable name (see https://unix.stackexchange.com/q/23659).Fix the variable name by replacing
-with_. Since the variable is unset before the script finishes, this presents minimal compatibility risk.Thanks for considering,
Kevin