schema: fix two regressions #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit af0d16d introduced the regression. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
thaJeztah
reviewed
Dec 9, 2025
Comment on lines
76
to
78
| "items": [ | ||
| { | ||
| "$ref": "defs-vm.json#/definitions/IOMemEntryFormat" | ||
| } | ||
| ] | ||
| "items": { | ||
| "anyOf": [ | ||
| { | ||
| "$ref": "defs-vm.json#/definitions/IOMemEntryFormat" | ||
| } | ||
| ] | ||
| } |
Member
There was a problem hiding this comment.
Not 100% sure if I understand this one; isn't items with a direct reference in it valid as well? That format is used in various other places, e.g.;
Lines 157 to 168 in fd25dd3
Member
Author
There was a problem hiding this comment.
it should an object, not an array.
I'll drop the anyOf.
Member
There was a problem hiding this comment.
Oh! I see it now; it was using an array for the items 👍 (sorry, the $anyOf put me on the wrong foot)
commit af0d16d introduced the regression. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
Author
|
@opencontainers/runtime-spec-maintainers PTAL |
utam0k
approved these changes
Dec 10, 2025
hqhq
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit af0d16d introduced the issues