Add time namespace / TimeOffsets check and helper #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tianon @kolyshkin @cyphar ping as you are the last 3 to have merged code here |
cyphar
requested changes
May 23, 2025
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
This requires timeOffsets support to really be usable. time namespaces without an offset aren't really any different to just using the host timens.
Contributor
Author
|
@cyphar added a check and an helper, is this what you were thinking ? |
champtar
changed the title
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
Contributor
Author
|
Ping @cyphar |
Contributor
Author
|
@cyphar can you review again ? |
cyphar
approved these changes
Oct 1, 2025
Contributor
Author
|
Do I need to do anything to get this merged ? (rebase so CI pass or ...) |
Contributor
|
Hmm, I don't know why CI is not kicking in. Let's close/reopen to kick it. |
Contributor
|
(it was waiting for approval to run CI, yet the "needs approval" was not shown unless you go to the CI job) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #783