fix: Only update downstream_customized for upstream-linked blocks #37412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/downstream-customized
branch
from
730ecd0 to
d02c317
Compare
|
@navinkarkera or @bradenmacdonald , could one of you review this? |
We only need to track field customizations for upstream-linked (i.e., library-linked) blocks. Thd downstream_customized field is irrelevant for other blocks. It would just add a ton of noise to the OLX. Fixes: openedx#37411
kdmccormick
force-pushed
the
kdmccormick/downstream-customized
branch
from
d02c317 to
6a8214f
Compare
navinkarkera
approved these changes
Oct 4, 2025
There was a problem hiding this comment.
@kdmccormick Thanks! I also noticed this bug and had a fix included in #37405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We only need to track field customizations for upstream-linked (i.e., library-linked) blocks. Thd downstream_customized field is irrelevant for other blocks. It would just add a ton of noise to the OLX.
Additionally, we now clear downstream_customized when severing an upstream link.
Supporting information
#37411
Testing
Without this PR:
downstream_customized="["display_name"]"(desired behavior)downstream_customized="["display_name"]"(bugged behavior)With this PR:
downstream_customized="["display_name"]")=downstream_customized="["display_name"]"Deadline
ASAP, but especially before the Ulmo so that this doesn't get into release operators' course data.
Since the downstream customization code was merged in September, some
downstream_customizedattributes will have gotten into 2U's and potentially MIT OL's course data. It won't be harmful there, just noisy.