fix: the display of username suggestions

[khudym]

Description

Username suggestions functionality has been corrected to ensure proper behaviour.

• fixed issue with suggestions being displayed in the wrong place;
• added the ability to navigate through suggestions using the keyboard.

Related Pull Requests
PR to the open-release/redwood.master branch: #1279
PR to the open-release/quince.master branch: #1278

Steps to Reproduce:

1. suggestions being displayed in the wrong place

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"

suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field

suggestions_keyboard.mov

After changes:

1. suggestions being displayed in the wrong place

fixed_suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

fixed_suggestions_keyboard.mov

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
• Is there adequate test coverage for your changes?

Post-merge Checklist

• Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @khudym!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.58%. Comparing base (f8a5cb5) to head (7197f4d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         124      124           
  Lines        2303     2304    +1     
  Branches      647      648    +1     
=======================================
+ Hits         2017     2018    +1     
  Misses        277      277           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mphilbrick211]

Friendly follow-up on this, @openedx/2u-vanguards. Thanks!

[mphilbrick211]

Hi @openedx/vanguards @openedx/2u-vanguards! I think you are still maintainers of this repo. Just checking in to see if someone could please take a look here?

[ihor-romaniuk]

Hello everyone,
It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment?
Thank you so much for your time and help!

[mphilbrick211]

Hello everyone, It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment? Thank you so much for your time and help!

@openedx/2u-infinity flagging this for you.

[mphilbrick211]

Hi @openedx/2u-infinity! Friendly ping on this.

[Copilot]

PR Overview

This PR fixes the display and navigation of username suggestions by updating both the saga logic used to fetch field validations and the UsernameField component’s rendering structure and accessibility attributes.

• Updated saga to cancel ongoing validation requests using race conditions when suggestions are cleared.
• Enhanced UsernameField’s accessibility by adding appropriate ARIA roles and tabIndex, and updated the layout for improved suggestion display.

Reviewed Changes

File	Description
src/register/data/sagas.js	Modified saga to cancel field validations when username suggestions are cleared.
src/register/RegistrationFields/UsernameField/UsernameField.jsx	Improved accessibility with ARIA roles and keyboard navigation; restructured layout for suggestion display.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/register/data/sagas.js:48

• Consider handling the cancellation case explicitly (e.g., dispatching a cancellation action or logging) when REGISTER_CLEAR_USERNAME_SUGGESTIONS is received, so that the system is aware that no response was obtained.

const { response } = yield race({

src/register/RegistrationFields/UsernameField/UsernameField.jsx:128

• The change from 'username-suggestions__error' to 'username-suggestions' may remove error-specific styling that was previously applied; please verify that error states are still properly styled elsewhere in the code.

className = 'username-suggestions';

[mphilbrick211]

Hi @awais-ansari! Is this all set? If so, could you merge when ready? Thanks!

[awais-ansari]

@khudym CLA check is failing.

[ihor-romaniuk]

@awais-ansari Hello
This request was provided within the corporate RaccoonGang agreement. Should I reopen this request on my behalf?

[sarina]

Hi @ihor-romaniuk - has the original author (@khudym ) left Raccoon Gang?

[ihor-romaniuk]

@sarina Yes, he left RaccoonGang

[sarina]

@ihor-romaniuk then this PR needs to be re-opened with commits under your name, because the CLA check won't pass. I'm closing this PR and you can link the new one when you create it.

[ihor-romaniuk]

@sarina I have reopened this pull requests on my behalf #1584

[sarina]

@ihor-romaniuk this change I think is ready to merge per @awais-ansari comment, but I will not be the one to approve/merge. Please reach out to Awais.

[awais-ansari]

Approved and merged