fix: Double click component card to edit #1598 #2447
+217
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/#1598
branch
3 times, most recently
from
c87691d to
218b65e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2447 +/- ##
==========================================
- Coverage 94.64% 94.64% -0.01%
==========================================
Files 1187 1187
Lines 26220 26233 +13
Branches 5839 5682 -157
==========================================
+ Hits 24817 24829 +12
- Misses 1333 1345 +12
+ Partials 70 59 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahtesham-quraish
force-pushed
the
ahtesham/#1598
branch
from
218b65e to
ac6ef11
Compare
| }); | ||
|
|
||
| it('should remove component from collection and hides sidebar', async () => { | ||
| jest.useFakeTimers(); // ✅ isolate fake timers for this test |
| // open sidebar | ||
| fireEvent.click(await screen.findByText(displayName)); | ||
|
|
||
| // ⏩ let the delayed sidebar open run |
| openComponentInfoSidebar(usageKey); | ||
| } | ||
| }, [usageKey, openItemSidebar, openComponentInfoSidebar, componentPickerMode]); | ||
| const selectComponent = useCallback( |
There was a problem hiding this comment.
Can we do it without using the timeout approach? I mean, can we maintain a state to decide which sidebar should render?
|
I'd like to define consistent behavior in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Double click component card to edit #1598
Supporting information
Screen.Recording.2025-09-16.at.2.14.10.PM.mov