Skip to content

Conversation

ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Oct 3, 2025

Description

Settings component for section, subsection and unit
#1976

Supporting information

image image image

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.70%. Comparing base (39e5f89) to head (c9daf42).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
+ Coverage   94.64%   94.70%   +0.05%     
==========================================
  Files        1188     1207      +19     
  Lines       26237    27012     +775     
  Branches     5690     5921     +231     
==========================================
+ Hits        24832    25581     +749     
- Misses       1346     1372      +26     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdaitzman
Copy link

Hi @ahtesham-quraish thank you for this contribution! Could you please update the PR description with a screen recording showing the implementation to support product review (or mark it as a draft if you're still making changes to the PR)?

@ahtesham-quraish
Copy link
Contributor Author

I have updated the PR with SS, please check now if you still need anything else let me know.

@bradenmacdonald
Copy link
Contributor

Thanks @ahtesham-quraish. @sdaitzman will review the screenshots and let us know if this looks ready to move forward.

BTW, I noticed you still have a lot of PRs open in this repo, most of which have changes that have been requested which you haven't addressed yet: https://github.com/openedx/frontend-app-authoring/pulls/ahtesham-quraish . Could you please either update or close those PRs before opening any new ones?

@edschema edschema requested review from edschema and removed request for edschema October 8, 2025 22:23
@edschema
Copy link

edschema commented Oct 8, 2025

Hi!
Subsection
The first segmented button should be "Ungraded" (not "Upgrade") and "Graded" (not "Grade")
The toggle for "Hide content after due date" is the correct darkness. This is because this option is not available when set to Ungraded.
The toggle for "only show results after due date" should have the same color as the other objects.

Unit
We made an error in copying over the design. This should be the design:
image

And the text should read:
"Unit settings cannot be configured within Libraries and must be set within a course. In a future release, Libraries may support configuring some settings."

We made a mistake here. Can you replace "can not" with "cannot"

Thank you!

@ahtesham-quraish
Copy link
Contributor Author

@edschema I have disabled the checkbox for unit I have used the paragon colors for making the checkbox disabled and label along with it gets disabled automatically. Can you please see this and let me know in case any change?

image

@ahtesham-quraish
Copy link
Contributor Author

ahtesham-quraish commented Oct 10, 2025

@bradenmacdonald I have updated the PRs and trying to addressed the comments many of them are ready to merge can you please merge them?

#2475
#2475
#2436
#2472
#2423
#2346

@edschema
Copy link

Minor nit: remove the space between "can not" to read "cannot". This is our mistake in the original designs. Besides that looks good to me if using default Paragon inactive styling. Thanks!

@ahtesham-quraish
Copy link
Contributor Author

can not

This is done you can check now. @edschema

@edschema
Copy link

@ahtesham-quraish @bradenmacdonald this looks good to me, ready for code review. Thanks!

@ahtesham-quraish
Copy link
Contributor Author

@bradenmacdonald can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants