Skip to content

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Oct 8, 2025

Description

This include multiple improvements described in #2528

  1. Fix: The title for the old version is clipped in the Standalone text override sync handling modal.
  2. Fix: For the update button dialog, there are a couple typos: eidts-> edits and discarted-> discarded. All in the Standalone text override sync handling modal.
  3. Fix: For the keep course dialog, please capitalize "If" for the second sentence. All in the Standalone text override sync handling modal.
  4. Reduced the spacing between blocks to 16px in select legacy libraries and select destination in the legacy libraries migration flow.
  5. Implemented the select all button in the select legacy libraries in the legacy libraries migration flow.
  6. Set the Unmigrated filter as the default in the select legacy libraries in the legacy libraries migration flow.
  7. Add the select border state in cards in the legacy libraries migration flow.
  8. Add auto scroll when creating a new library in the legacy libraries migration flow.
  9. Get the iframe of blocks-v1 and deleted the alert in the sync component modal.

Supporting information

Testing instructions

  1. Fix: The title for the old version is clipped in the Standalone text override sync handling modal.
  2. Fix: For the update button dialog, there are a couple typos: eidts-> edits and discarted-> discarded. All in the Standalone text override sync handling modal.
  3. Fix: For the keep course dialog, please capitalize "If" for the second sentence. All in the Standalone text override sync handling modal.
  4. Reduced the spacing between blocks to 16px in select legacy libraries and select destination in the legacy libraries migration flow.
    • Create some legacy libraries.
    • In the legacy libraries tab click on Review Legacy Libraries
    • Verify this fix in the select legacy libraries step and in the select destination step.
  5. Implemented the select all button in the select legacy libraries in the legacy libraries migration flow.
    • In the select legacy libraries step, test the Select all button.
  6. Set the Unmigrated filter as the default in the select legacy libraries in the legacy libraries migration flow.
    • In the select legacy libraries step, verify that the Unmigrated filter is the default.
  7. Add the select border state in cards in the legacy libraries migration flow.
    • In the select legacy libraries step and in the select destination step, verify the new card state when is selected.
  8. Add auto scroll when creating a new library in the legacy libraries migration flow.
    • In the select destination step, create a new library, verify that the new library is selected, and there is an auto scroll to the card.
  9. Get the iframe of blocks-v1 and delete the alert in the sync component modal.
    • In a course add some component (not text) from a library
    • Rename the component in the course.
    • Update the component in the library and publish it.
    • Open the sync modal in the course.
    • Verify that the course version shows the block-v1 iframe.
    • Verify that the alert is gone.

Other information

Merge this before the Ulmo cut

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 8, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV ChrisChV marked this pull request as draft October 8, 2025 20:43
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.71%. Comparing base (aadccc7) to head (ac194c8).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2529   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files        1202     1202           
  Lines       26845    26862   +17     
  Branches     6024     6036   +12     
=======================================
+ Hits        25425    25442   +17     
+ Misses       1361     1350   -11     
- Partials       59       70   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV marked this pull request as ready for review October 10, 2025 00:20
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @ChrisChV!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but the code looks good, once you address those nits. Thanks!

@ChrisChV ChrisChV merged commit 46d2465 into openedx:master Oct 13, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Oct 13, 2025
@ChrisChV ChrisChV deleted the chris/style-nits branch October 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants