-
Notifications
You must be signed in to change notification settings - Fork 53
feat: same titles for sent email groups #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: same titles for sent email groups #259
Conversation
Co-authored-by: Braden MacDonald <mail@bradenm.com>
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 83.26% 84.29% +1.03%
==========================================
Files 47 50 +3
Lines 693 707 +14
Branches 135 134 -1
==========================================
+ Hits 577 596 +19
+ Misses 116 111 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reopened Pull Request based on #205
Description
this PR proposes making the display of mail recipients the same for all places (checkbox labels, Send email alert modal, Scheduled emails table with View Modal, Email Task History)
Steps to reproduce
click on "Staff/Administrators" checkbox -> complete the form (subject, body) -> options:
(in this modal you can see the difference between recipients titles and selected checkbox label)
-> click "Continue" button -> wait for the "Scheduled emails" table to load and also compare titles in "Send to" column
Screenshots before
Example with selected "Staff/Administrators"
Example with selected "All Learners"
Screenshots after